Skip to content

Commit a6d4772

Browse files
authored
Preview viewer: don't show stack trace to users (#14231)
* Don't show stack trace to users * IntelliJ reformat
1 parent 2844a09 commit a6d4772

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package org.jabref.gui.preview;
22

33
import java.io.IOException;
4-
import java.io.PrintWriter;
5-
import java.io.StringWriter;
64
import java.net.MalformedURLException;
75
import java.util.List;
86
import java.util.Objects;
@@ -210,13 +208,17 @@ private void update() {
210208
}
211209

212210
private String formatError(BibEntry entry, Throwable exception) {
213-
StringWriter sw = new StringWriter();
214-
exception.printStackTrace(new PrintWriter(sw));
215-
return "%s\n\n%s\n\nBibTeX (internal):\n%s\n\nStack Trace:\n%s".formatted(
211+
LOGGER.error("Error generating preview for entry: {}", entry.getCitationKey(), exception);
212+
213+
return """
214+
<div class="error">
215+
<h3>%s</h3>
216+
<p>%s</p>
217+
<p><small>Check the event logs for details.</small></p>
218+
</div>
219+
""".formatted(
216220
Localization.lang("Error while generating citation style"),
217-
exception.getLocalizedMessage(),
218-
entry,
219-
sw);
221+
exception.getLocalizedMessage() != null ? exception.getLocalizedMessage() : "Unknown error");
220222
}
221223

222224
private void setPreviewText(String text) {

0 commit comments

Comments
 (0)