Change recursion into two calls (#14184)

Author: koppor

jabgui/src/main/java/org/jabref/gui/entryeditor/EntryEditor.java

@@ -494,29 +494,33 @@ private void fetchAndMerge(EntryBasedFetcher fetcher) {
 
     public void setFocusToField(Field field) {
         UiTaskExecutor.runInJavaFXThread(() -> {
-            Field actualField = field;
-            boolean fieldFound = false;
-            for (Tab tab : tabbed.getTabs()) {
-                tabbed.getSelectionModel().select(tab);
-                if ((tab instanceof FieldsEditorTab fieldsEditorTab)
-                        && fieldsEditorTab.getShownFields().contains(actualField)) {
-                    tabbed.getSelectionModel().select(tab);
-                    Platform.runLater(() -> fieldsEditorTab.requestFocus(actualField));
-                    // This line explicitly brings focus back to the main window containing the Entry Editor.
-                    getScene().getWindow().requestFocus();
-                    fieldFound = true;
-                    break;
-                }
-            }
-            if (!fieldFound) {
-                Field aliasField = EntryConverter.FIELD_ALIASES.get(field);
-                if (aliasField != null) {
-                    setFocusToField(aliasField);
-                }
-            }
+            getTabContainingField(field).ifPresentOrElse(
+                    tab -> selectTabAndField(tab, field),
+                    () -> {
+                        Field aliasField = EntryConverter.FIELD_ALIASES.get(field);
+                        getTabContainingField(aliasField).ifPresent(tab -> selectTabAndField(tab, aliasField));
+                    }
+            );
         });
     }
 
+    private void selectTabAndField(FieldsEditorTab tab, Field field) {
+        Platform.runLater(() -> {
+            tabbed.getSelectionModel().select(tab);
+            tab.requestFocus(field);
+        });
+        // This line explicitly brings focus back to the main window containing the Entry Editor.
+        getScene().getWindow().requestFocus();
+    }
+
+    private Optional<FieldsEditorTab> getTabContainingField(Field field) {
+        return tabbed.getTabs().stream()
+                     .filter(FieldsEditorTab.class::isInstance)
+                     .map(FieldsEditorTab.class::cast)
+                     .filter(tab -> tab.getShownFields().contains(field))
+                     .findFirst();
+    }
+
     @Override
     public void nextPreviewStyle() {
         this.previewPanel.nextPreviewStyle();