Skip to content

Commit e9383ea

Browse files
jsochavajsochava
committed
trying to fix format errors in pr draft (#14085)
1 parent 711c3a9 commit e9383ea

File tree

459 files changed

+161014
-64169
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

459 files changed

+161014
-64169
lines changed

‎.devcontainer/devcontainer.json‎

Lines changed: 36 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,39 @@
11
{
2-
"name": "Java",
3-
"image": "mcr.microsoft.com/devcontainers/base:debian",
4-
"customizations": {
5-
"vscode": {
6-
"extensions": [
7-
"vscjava.vscode-java-pack",
8-
"vscjava.vscode-gradle",
9-
"shengchen.vscode-checkstyle",
10-
"DavidAnson.vscode-markdownlint"
11-
]
12-
}
13-
},
14-
15-
// Source code generation needs to be done before hand-over to VS Code.
16-
// Otherwise, the Java extension will go mad.
17-
"onCreateCommand": "./gradlew testClasses --console=plain --no-daemon",
18-
19-
// Forward the vncPort and noVNC port.
20-
// They are provided by desktop-lite:
21-
// https://github.com/devcontainers/features/tree/main/src/desktop-lite#options
22-
"forwardPorts": [5901, 6080],
23-
24-
// Need to connect as root otherwise we run into issues with gradle.
25-
// default option is "vscode". More info: https://aka.ms/vscode-remote/containers/non-root.
26-
"remoteUser": "root",
27-
"features": {
28-
// Adds a lightweight desktop that can be accessed using a VNC viewer or the web
29-
"ghcr.io/devcontainers/features/desktop-lite:1": {},
30-
31-
// Install java.
32-
// See https://github.com/devcontainers/features/tree/main/src/java#options for details.
33-
"ghcr.io/devcontainers/features/java:1": {
34-
"version": "24.0.2-amzn",
35-
"installGradle": true,
36-
"gradleVersion": "8.14.3",
37-
"jdkDistro": "Corretto"
38-
}
2+
"name": "Java",
3+
"image": "mcr.microsoft.com/devcontainers/base:debian",
4+
"customizations": {
5+
"vscode": {
6+
"extensions": [
7+
"vscjava.vscode-java-pack",
8+
"vscjava.vscode-gradle",
9+
"shengchen.vscode-checkstyle",
10+
"DavidAnson.vscode-markdownlint"
11+
]
3912
}
13+
},
14+
// Source code generation needs to be done before hand-over to VS Code.
15+
// Otherwise, the Java extension will go mad.
16+
"onCreateCommand": "./gradlew testClasses --console=plain --no-daemon",
17+
// Forward the vncPort and noVNC port.
18+
// They are provided by desktop-lite:
19+
// https://github.com/devcontainers/features/tree/main/src/desktop-lite#options
20+
"forwardPorts": [
21+
5901,
22+
6080
23+
],
24+
// Need to connect as root otherwise we run into issues with gradle.
25+
// default option is "vscode". More info: https://aka.ms/vscode-remote/containers/non-root.
26+
"remoteUser": "root",
27+
"features": {
28+
// Adds a lightweight desktop that can be accessed using a VNC viewer or the web
29+
"ghcr.io/devcontainers/features/desktop-lite:1": {},
30+
// Install java.
31+
// See https://github.com/devcontainers/features/tree/main/src/java#options for details.
32+
"ghcr.io/devcontainers/features/java:1": {
33+
"version": "24.0.2-amzn",
34+
"installGradle": true,
35+
"gradleVersion": "8.14.3",
36+
"jdkDistro": "Corretto"
37+
}
38+
}
4039
}

‎.github/ISSUE_TEMPLATE/suggestion-for-improvement.md‎

Lines changed: 61 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,66 @@ Requests for completely new features, questions and general feedback is now hand
1414
Thanks!
1515
-->
1616

17-
**Is your suggestion for improvement related to a problem? Please describe.**
18-
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
17+
*
18+
*Is
19+
your
20+
suggestion
21+
for
22+
improvement
23+
related
24+
to
25+
a
26+
problem?
27+
Please
28+
describe.
29+
**
30+
A
31+
clear
32+
and
33+
concise
34+
description
35+
of
36+
what
37+
the
38+
problem
39+
is.
40+
Ex.
41+
I'm
42+
always
43+
frustrated
44+
when [...]
1945

20-
**Describe the solution you'd like**
21-
A clear and concise description of what you want to happen.
46+
*
47+
*Describe
48+
the
49+
solution
50+
you'd
51+
like
52+
**
53+
A
54+
clear
55+
and
56+
concise
57+
description
58+
of
59+
what
60+
you
61+
want
62+
to
63+
happen.
2264

23-
**Additional context**
24-
Add any other context or screenshots about the feature request here.
65+
*
66+
*Additional
67+
context
68+
**
69+
Add
70+
any
71+
other
72+
context
73+
or
74+
screenshots
75+
about
76+
the
77+
feature
78+
request
79+
here.

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 105 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,108 @@ Keep ALL the items. Replace the dots inside [.] and mark them as follows:
2424
[/] not applicable
2525
-->
2626

27-
- [x] I own the copyright of the code submitted and I license it under the [MIT license](https://github.com/JabRef/jabref/blob/main/LICENSE)
28-
- [.] I manually tested my changes in running JabRef (always required)
29-
- [.] I added JUnit tests for changes (if applicable)
30-
- [.] I added screenshots in the PR description (if change is visible to the user)
31-
- [.] I described the change in `CHANGELOG.md` in a way that is understandable for the average user (if change is visible to the user)
32-
- [.] I checked the [user documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request updating file(s) in <https://github.com/JabRef/user-documentation/tree/main/en>.
27+
- [x]
28+
I
29+
own
30+
the
31+
copyright
32+
of
33+
the
34+
code
35+
submitted
36+
and
37+
I
38+
license
39+
it
40+
under
41+
the [MIT license](https://github.com/JabRef/jabref/blob/main/LICENSE)
42+
- [.]
43+
I
44+
manually
45+
tested
46+
my
47+
changes
48+
in
49+
running
50+
JabRef (
51+
always
52+
required)
53+
- [.]
54+
I
55+
added
56+
JUnit
57+
tests
58+
for
59+
changes (
60+
if
61+
applicable)
62+
- [.]
63+
I
64+
added
65+
screenshots
66+
in
67+
the
68+
PR
69+
description (
70+
if
71+
change
72+
is
73+
visible
74+
to
75+
the
76+
user)
77+
- [.]
78+
I
79+
described
80+
the
81+
change
82+
in
83+
`CHANGELOG.md`
84+
in
85+
a
86+
way
87+
that
88+
is
89+
understandable
90+
for
91+
the
92+
average
93+
user (
94+
if
95+
change
96+
is
97+
visible
98+
to
99+
the
100+
user)
101+
- [.]
102+
I
103+
checked
104+
the [user documentation](https://docs.jabref.org/):
105+
Is
106+
the
107+
information
108+
available
109+
and
110+
up
111+
to
112+
date?
113+
If
114+
not,
115+
I
116+
created
117+
an
118+
issue
119+
at <https://github.com/JabRef/user-documentation/issues>
120+
or,
121+
even
122+
better,
123+
I
124+
submitted
125+
a
126+
pull
127+
request
128+
updating
129+
file(
130+
s)
131+
in <https://github.com/JabRef/user-documentation/tree/main/en>.

‎.github/workflows/automerge.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: Auto Merge
2-
on: [pull_request_target, workflow_dispatch]
2+
on: [ pull_request_target, workflow_dispatch ]
33

44
permissions:
55
contents: write
@@ -11,8 +11,8 @@ jobs:
1111
if: github.repository == 'JabRef/jabref'
1212
env:
1313
HEAD_REPO: ${{ github.event.pull_request.head.repo.full_name }}
14-
USER: ${{ github.event.pull_request.user.login }}
15-
TITLE: ${{ github.event.pull_request.title }}
14+
USER: ${{ github.event.pull_request.user.login }}
15+
TITLE: ${{ github.event.pull_request.title }}
1616
steps:
1717
- name: Determine if job should run
1818
id: shouldrun

‎.github/workflows/binaries.yml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ jobs:
129129
fi
130130
131131
build:
132-
needs: [conditions]
132+
needs: [ conditions ]
133133
if: ${{ needs.conditions.outputs.should-build == 'true' }}
134134
strategy:
135135
fail-fast: false
@@ -355,7 +355,7 @@ jobs:
355355
comment-on-pr:
356356
name: Comment on PR
357357
# separate job, because it should wait until all binaries are available
358-
needs: [conditions, build]
358+
needs: [ conditions, build ]
359359
if: ${{ (github.event_name == 'pull_request') && (needs.conditions.outputs.upload-to-builds-jabref-org == 'true') }}
360360
runs-on: ubuntu-latest
361361
steps:
@@ -370,7 +370,7 @@ jobs:
370370
comment-on-issue:
371371
name: Comment on issue
372372
# separate job, because it should wait until all binaries are available
373-
needs: [conditions, build]
373+
needs: [ conditions, build ]
374374
if: ${{ (github.event_name == 'pull_request') && (needs.conditions.outputs.upload-to-builds-jabref-org == 'true') }}
375375
runs-on: ubuntu-latest
376376
steps:
@@ -401,18 +401,18 @@ jobs:
401401
with:
402402
pr-number: ${{ steps.get_issue_number.outputs.ticketNumber }}
403403
message: >
404-
A pull request addressing the issue has been created.
405-
The build of this PR is available at <https://builds.jabref.org/pull/${{ github.event.pull_request.number }}/merge>.
404+
A pull request addressing the issue has been created.
405+
The build of this PR is available at <https://builds.jabref.org/pull/${{ github.event.pull_request.number }}/merge>.
406406
407407
408-
For any feedback, add a comment to the pull request at ${{ github.event.pull_request.html_url }}.
408+
For any feedback, add a comment to the pull request at ${{ github.event.pull_request.html_url }}.
409409
comment-tag: download-link
410410
mode: recreate
411411

412412
notarize:
413413
# Outsourced in a separate job to be able to rerun if this fails for timeouts
414414
name: macOS notarization
415-
needs: [conditions, build]
415+
needs: [ conditions, build ]
416416
if: ${{ needs.conditions.outputs.should-notarize == 'true' }}
417417
strategy:
418418
# Ensure that calls to Apple are sequentially made

‎.github/workflows/cleanup-pr.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Cleanup after PR
22

33
on:
44
pull_request:
5-
types: [closed]
5+
types: [ closed ]
66

77
jobs:
88
cleanup:

‎.github/workflows/dockerimages.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
if: ${{ github.repository_owner == 'JabRef' }}
2626
strategy:
2727
matrix:
28-
component: [jabkit, jabsrv]
28+
component: [ jabkit, jabsrv ]
2929
runs-on: ubuntu-latest
3030
steps:
3131
- name: Docker meta

‎.github/workflows/gource.yml‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,23 @@ jobs:
2626
start: '2025-04-15'
2727
end: ''
2828
file: 'jabref-v6.0-dev.mp4'
29-
# - title: 'JabRef v6.0-alpha2 | more information at contribute.jabref.org'
30-
# start: '2024-12-23'
31-
# end: '2025-04-27'
32-
# file: 'jabref-v6.0-alpha2.mp4'
33-
# - title: 'JabRef v6.0-alpha | more information at contribute.jabref.org'
34-
# start: '2024-07-10'
35-
# end: '2024-12-23'
36-
# file: 'jabref-v6.0-alpha.mp4'
29+
# - title: 'JabRef v6.0-alpha2 | more information at contribute.jabref.org'
30+
# start: '2024-12-23'
31+
# end: '2025-04-27'
32+
# file: 'jabref-v6.0-alpha2.mp4'
33+
# - title: 'JabRef v6.0-alpha | more information at contribute.jabref.org'
34+
# start: '2024-07-10'
35+
# end: '2024-12-23'
36+
# file: 'jabref-v6.0-alpha.mp4'
3737
- title: 'JabRef v6.x | more information at contribute.jabref.org'
3838
start: '2024-07-10'
3939
end: ''
4040
file: 'jabref-v6.x.mp4'
41-
# - title: 'JabRef v5.x | more information at contribute.jabref.org'
42-
# start: '2018-06-05'
43-
# end: '2024-07-10'
44-
# file: 'jabref-v5.x.mp4'
45-
# seconds_per_day: '0.5'
41+
# - title: 'JabRef v5.x | more information at contribute.jabref.org'
42+
# start: '2018-06-05'
43+
# end: '2024-07-10'
44+
# file: 'jabref-v5.x.mp4'
45+
# seconds_per_day: '0.5'
4646
- title: 'JabRef | more information at contribute.jabref.org'
4747
start: ''
4848
end: ''

0 commit comments

Comments
 (0)