ESC closes the preferences dialog when editing table. (#14106)

* Change preferences dialog behaviour so esc key press is not consumed by cell-based controls (ListView/TableView/TreeView/TreeTableView)

* WIP: local changes before rebase

* Changes in the fix

* added changes in the code

* Fix submodules

* add changelog

---------

Co-authored-by: Callum Higginson <[email protected]>
Co-authored-by: Vishakha <[email protected]>
Co-authored-by: Subhramit Basu <[email protected]>
Co-authored-by: Christoph <[email protected]>

Author: 5 people

CHANGELOG.md

@@ -15,6 +15,8 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ### Fixed
 
+- We fixed an issue where pressing <kbd>ESC</kbd> in the preferences dialog would not always close the dialog. [#8888](https://github.com/JabRef/jabref/issues/8888)
+
 ### Removed
 
 ## [6.0-alpha.3] – 2025-10-30

jabgui/src/main/java/org/jabref/gui/preferences/PreferencesDialogView.java

@@ -7,8 +7,12 @@
 import javafx.scene.control.ButtonType;
 import javafx.scene.control.ListView;
 import javafx.scene.control.ScrollPane;
+import javafx.scene.control.TableView;
 import javafx.scene.control.ToggleButton;
+import javafx.scene.control.TreeTableView;
+import javafx.scene.control.TreeView;
 import javafx.scene.input.KeyCode;
+import javafx.scene.input.KeyEvent;
 
 import org.jabref.gui.DialogService;
 import org.jabref.gui.icon.IconTheme;
@@ -93,6 +97,14 @@ private void initialize() {
                 preferencesContainer.setContent(preferencesTab.getBuilder());
                 preferencesTab.prefWidthProperty().bind(preferencesContainer.widthProperty().subtract(10d));
                 preferencesTab.getStyleClass().add("preferencesTab");
+                this.getDialogPane().addEventFilter(KeyEvent.KEY_PRESSED, event -> {
+                    if (preferences.getKeyBindingRepository().checkKeyCombinationEquality(KeyBinding.CLOSE, event)) {
+                        if (event.getTarget() instanceof ListView || event.getTarget() instanceof TableView || event.getTarget() instanceof TreeView || event.getTarget() instanceof TreeTableView) {
+                            this.closeDialog();
+                            event.consume();
+                        }
+                    }
+                });
             } else {
                 preferencesContainer.setContent(null);
             }