-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Closed
Labels
good first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.📌 Pinned📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Milestone
Description
In #13401, we switched the build tooling. Thereby, we "renamed" Java modules. This causes issues: APIdia-net/apidia.net#2 (comment)
Task: Semantically (revert) the update
- Adapt module names in to generate the names as they were before
jabref/build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts
Line 80 in 28b7350
extraJavaModuleInfo { - Adapt all
module-info.javaaccordingly.
The diff for one module java is determined as follows
$ git diff 8f92294561fe7b93530f46d7f8fe394cbdb12441 main -- jablib/src/main/java/module-info.java This has to be reverted (and new updates be kept)
- requires flexmark;
- requires flexmark.html2md.converter;
- requires flexmark.util.ast;
- requires flexmark.util.data;
+ requires com.vladsch.flexmark;
+ requires com.vladsch.flexmark.html2md.converter;
+ requires com.vladsch.flexmark.util.ast;(and much more)
Hints
⚠ This is a good to about build systems. This issue cannot be solved with an AI (alone). You really have to think though the build systems for yourself! Take this issue only if you are willing to invest significant time. ⚠
- Execute the gradle task: jabgui > application > run to check if the system builds. If not, you need to adapt the
.ktsand/ormodule-info.javafiles. - This is more a code-and-fix task
- The build will take some seconds until you get feedback. Reserve some time and be prepared to "idle".
- A first test is that JabGui runs; tests if it fits for Status Log of JabRef 5.15 APIdia-net/apidia.net#2 (comment) can be done by
jar --file flexmark-0.64.8.jar -d. You will find the jars by everything. Is much effort. If this is too much effort for you, you can submit a PR and then askSteworito check.
Metadata
Metadata
Assignees
Labels
good first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.📌 Pinned📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Type
Projects
Status
In Progress