From c0086755ba035990cd6c3329f3dfc5988d1cce5b Mon Sep 17 00:00:00 2001 From: Rishivardhan Date: Wed, 12 Mar 2025 15:54:29 +0530 Subject: [PATCH 1/6] replacing "Cleanup entries" to "Clean up entries" --- CHANGELOG.md | 1 + src/main/java/org/jabref/gui/actions/StandardActions.java | 2 +- src/main/java/org/jabref/gui/cleanup/CleanupAction.java | 2 +- src/main/java/org/jabref/gui/cleanup/CleanupDialog.java | 2 +- src/main/java/org/jabref/gui/keyboard/KeyBinding.java | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 74b1e996508..249f56d68c9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -72,6 +72,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed an issue where migration of "Search groups" would fail with an exception when the search query is invalid. [#12555](https://github.com/JabRef/jabref/issues/12555) - We fixed an issue where not all linked files from BibDesk in the field `bdsk-file-...` were parsed. [#12555](https://github.com/JabRef/jabref/issues/12555) - We fixed an issue where JabRef displayed an incorrect deletion notification when canceling entry deletion [#12645](https://github.com/JabRef/jabref/issues/12645) +- We fixed an issue where JabRef displayed "Cleanup entries" instead of "Clean up entries" https://github.com/JabRef/jabref/issues/12703 ### Removed diff --git a/src/main/java/org/jabref/gui/actions/StandardActions.java b/src/main/java/org/jabref/gui/actions/StandardActions.java index 96c36b20c24..31a9b79c7cb 100644 --- a/src/main/java/org/jabref/gui/actions/StandardActions.java +++ b/src/main/java/org/jabref/gui/actions/StandardActions.java @@ -150,7 +150,7 @@ public enum StandardActions implements Action { GENERATE_CITE_KEY(Localization.lang("Generate citation key"), IconTheme.JabRefIcons.MAKE_KEY, KeyBinding.AUTOGENERATE_CITATION_KEYS), GENERATE_CITE_KEYS(Localization.lang("Generate citation keys"), IconTheme.JabRefIcons.MAKE_KEY, KeyBinding.AUTOGENERATE_CITATION_KEYS), DOWNLOAD_FULL_TEXT(Localization.lang("Search full text documents online"), IconTheme.JabRefIcons.FILE_SEARCH, KeyBinding.DOWNLOAD_FULL_TEXT), - CLEANUP_ENTRIES(Localization.lang("Cleanup entries"), IconTheme.JabRefIcons.CLEANUP_ENTRIES, KeyBinding.CLEANUP), + CLEANUP_ENTRIES(Localization.lang("Clean up entries"), IconTheme.JabRefIcons.CLEANUP_ENTRIES, KeyBinding.CLEANUP), SET_FILE_LINKS(Localization.lang("Automatically set file links"), KeyBinding.AUTOMATICALLY_LINK_FILES), EDIT_FILE_LINK(Localization.lang("Edit"), IconTheme.JabRefIcons.EDIT, KeyBinding.OPEN_CLOSE_ENTRY_EDITOR), diff --git a/src/main/java/org/jabref/gui/cleanup/CleanupAction.java b/src/main/java/org/jabref/gui/cleanup/CleanupAction.java index 3be3143ab58..08c7ec33b8a 100644 --- a/src/main/java/org/jabref/gui/cleanup/CleanupAction.java +++ b/src/main/java/org/jabref/gui/cleanup/CleanupAction.java @@ -145,7 +145,7 @@ private void showResults() { private void cleanup(BibDatabaseContext databaseContext, CleanupPreferences cleanupPreferences) { this.failures.clear(); - NamedCompound ce = new NamedCompound(Localization.lang("Cleanup entries")); + NamedCompound ce = new NamedCompound(Localization.lang("Clean up entries")); for (BibEntry entry : stateManager.getSelectedEntries()) { // undo granularity is on entry level diff --git a/src/main/java/org/jabref/gui/cleanup/CleanupDialog.java b/src/main/java/org/jabref/gui/cleanup/CleanupDialog.java index 380dea76fe2..752b9309dc6 100644 --- a/src/main/java/org/jabref/gui/cleanup/CleanupDialog.java +++ b/src/main/java/org/jabref/gui/cleanup/CleanupDialog.java @@ -11,7 +11,7 @@ public class CleanupDialog extends BaseDialog { public CleanupDialog(BibDatabaseContext databaseContext, CleanupPreferences initialPreset, FilePreferences filePreferences) { - setTitle(Localization.lang("Cleanup entries")); + setTitle(Localization.lang("Clean up entries")); getDialogPane().setPrefSize(600, 650); getDialogPane().getButtonTypes().setAll(ButtonType.OK, ButtonType.CANCEL); diff --git a/src/main/java/org/jabref/gui/keyboard/KeyBinding.java b/src/main/java/org/jabref/gui/keyboard/KeyBinding.java index 2d9a7e1d78b..562723b910e 100644 --- a/src/main/java/org/jabref/gui/keyboard/KeyBinding.java +++ b/src/main/java/org/jabref/gui/keyboard/KeyBinding.java @@ -31,7 +31,7 @@ public enum KeyBinding { AUTOMATICALLY_LINK_FILES("Automatically link files", Localization.lang("Automatically set file links"), "F7", KeyBindingCategory.QUALITY), CHECK_INTEGRITY("Check integrity", Localization.lang("Check integrity"), "ctrl+F8", KeyBindingCategory.QUALITY), CHECK_CONSISTENCY("Check consistency", Localization.lang("Check consistency"), "ctrl+F9", KeyBindingCategory.QUALITY), - CLEANUP("Cleanup", Localization.lang("Cleanup entries"), "alt+F8", KeyBindingCategory.QUALITY), + CLEANUP("Clean up", Localization.lang("Clean up entries"), "alt+F8", KeyBindingCategory.QUALITY), CLOSE_DATABASE("Close library", Localization.lang("Close library"), "ctrl+W", KeyBindingCategory.FILE), CLOSE("Close dialog", Localization.lang("Close dialog"), "Esc", KeyBindingCategory.VIEW), COPY("Copy", Localization.lang("Copy"), "ctrl+C", KeyBindingCategory.EDIT), From 5213052d1948e94b1b4c16601714e6edcdeacfbf Mon Sep 17 00:00:00 2001 From: Rishivardhan Date: Wed, 12 Mar 2025 16:15:05 +0530 Subject: [PATCH 2/6] test formatting changes on CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 249f56d68c9..1cc0f21c8e7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -72,7 +72,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed an issue where migration of "Search groups" would fail with an exception when the search query is invalid. [#12555](https://github.com/JabRef/jabref/issues/12555) - We fixed an issue where not all linked files from BibDesk in the field `bdsk-file-...` were parsed. [#12555](https://github.com/JabRef/jabref/issues/12555) - We fixed an issue where JabRef displayed an incorrect deletion notification when canceling entry deletion [#12645](https://github.com/JabRef/jabref/issues/12645) -- We fixed an issue where JabRef displayed "Cleanup entries" instead of "Clean up entries" https://github.com/JabRef/jabref/issues/12703 +- We fixed an issue where JabRef displayed "Cleanup entries" instead of "Clean up entries" [#12710](https://github.com/JabRef/jabref/issues/12710) ### Removed From 15c1f0058df86d77cfcca45b2a1c28a85f34f252 Mon Sep 17 00:00:00 2001 From: Rishivardhan Date: Wed, 12 Mar 2025 16:42:02 +0530 Subject: [PATCH 3/6] replacing "Cleanup entries" to "Clean up entries" --- src/main/resources/l10n/JabRef_en.properties | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties index 40fa26c0291..6d3508e58d8 100644 --- a/src/main/resources/l10n/JabRef_en.properties +++ b/src/main/resources/l10n/JabRef_en.properties @@ -1213,7 +1213,7 @@ Use\ abbreviated\ firstname\ whenever\ possible=Use abbreviated firstname whenev Use\ abbreviated\ and\ full\ firstname=Use abbreviated and full firstname Name\ format=Name format First\ names=First names -Cleanup\ entries=Cleanup entries +Clean\ up\ entries=Clean up entries Automatically\ assign\ new\ entry\ to\ selected\ groups=Automatically assign new entry to selected groups %0\ mode=%0 mode Move\ DOIs\ from\ 'note'\ field\ and\ 'URL'\ field\ to\ 'DOI'\ field\ and\ remove\ http\ prefix=Move DOIs from 'note' field and 'URL' field to 'DOI' field and remove http prefix @@ -1332,7 +1332,7 @@ Convert\ to\ BibTeX\ format\ (e.g.,\ store\ publication\ date\ in\ year\ and\ mo Deprecated\ fields=Deprecated fields Shows\ fields\ having\ a\ successor\ in\ biblatex.=Shows fields having a successor in biblatex. -Shows\ fields\ having\ a\ successor\ in\ biblatex.\nFor\ instance,\ the\ publication\ month\ should\ be\ part\ of\ the\ date\ field.\nUse\ the\ Cleanup\ Entries\ functionality\ to\ convert\ the\ entry\ to\ biblatex.=Shows fields having a successor in biblatex.\nFor instance, the publication month should be part of the date field.\nUse the Cleanup Entries functionality to convert the entry to biblatex. +Shows\ fields\ having\ a\ successor\ in\ biblatex.\nFor\ instance,\ the\ publication\ month\ should\ be\ part\ of\ the\ date\ field.\nUse\ the\ Cleanup\ Entries\ functionality\ to\ convert\ the\ entry\ to\ biblatex.=Shows fields having a successor in biblatex.\nFor instance, the publication month should be part of the date field.\nUse the Clean up Entries functionality to convert the entry to biblatex. No\ read\ status\ information=No read status information From ac83bde152a3a5a89a1e1e92ea5c7774845f0861 Mon Sep 17 00:00:00 2001 From: Rishivardhan Date: Wed, 12 Mar 2025 18:12:10 +0530 Subject: [PATCH 4/6] replacing "Cleanup entries" to "Clean up entries" --- CHANGELOG.md | 2 +- .../java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java | 2 +- src/main/resources/l10n/JabRef_en.properties | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1cc0f21c8e7..087532c44e7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -49,6 +49,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We removed the obsolete Twitter link and added Mastodon and LinkedIn links in Help -> JabRef resources. [#12660](https://github.com/JabRef/jabref/issues/12660) - We improved the Check Integrity dialog entry interaction so that a single click focuses on the corresponding entry and a double-click both focuses on the entry and closes the dialog. [#12245](https://github.com/JabRef/jabref/issues/12245) - We improved journal abbreviation lookup with fuzzy matching to handle minor input errors and variations. [#12467](https://github.com/JabRef/jabref/issues/12467) +- We changed a text JabRef displayed "Cleanup entries" instead of "Clean up entries" [#12710](https://github.com/JabRef/jabref/issues/12710) ### Fixed @@ -72,7 +73,6 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed an issue where migration of "Search groups" would fail with an exception when the search query is invalid. [#12555](https://github.com/JabRef/jabref/issues/12555) - We fixed an issue where not all linked files from BibDesk in the field `bdsk-file-...` were parsed. [#12555](https://github.com/JabRef/jabref/issues/12555) - We fixed an issue where JabRef displayed an incorrect deletion notification when canceling entry deletion [#12645](https://github.com/JabRef/jabref/issues/12645) -- We fixed an issue where JabRef displayed "Cleanup entries" instead of "Clean up entries" [#12710](https://github.com/JabRef/jabref/issues/12710) ### Removed diff --git a/src/main/java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java b/src/main/java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java index 6bef4bf0dd8..cd4070c3a40 100644 --- a/src/main/java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java +++ b/src/main/java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java @@ -56,7 +56,7 @@ public DeprecatedFieldsTab(BibDatabaseContext databaseContext, setText(Localization.lang("Deprecated fields")); EasyBind.subscribe(preferences.getWorkspacePreferences().showAdvancedHintsProperty(), advancedHints -> { if (advancedHints) { - setTooltip(new Tooltip(Localization.lang("Shows fields having a successor in biblatex.\nFor instance, the publication month should be part of the date field.\nUse the Cleanup Entries functionality to convert the entry to biblatex."))); + setTooltip(new Tooltip(Localization.lang("Shows fields having a successor in biblatex.\nFor instance, the publication month should be part of the date field.\nUse the Clean up Entries functionality to convert the entry to biblatex."))); } else { setTooltip(new Tooltip(Localization.lang("Shows fields having a successor in biblatex."))); } diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties index 6d3508e58d8..a7737a9a456 100644 --- a/src/main/resources/l10n/JabRef_en.properties +++ b/src/main/resources/l10n/JabRef_en.properties @@ -1332,7 +1332,7 @@ Convert\ to\ BibTeX\ format\ (e.g.,\ store\ publication\ date\ in\ year\ and\ mo Deprecated\ fields=Deprecated fields Shows\ fields\ having\ a\ successor\ in\ biblatex.=Shows fields having a successor in biblatex. -Shows\ fields\ having\ a\ successor\ in\ biblatex.\nFor\ instance,\ the\ publication\ month\ should\ be\ part\ of\ the\ date\ field.\nUse\ the\ Cleanup\ Entries\ functionality\ to\ convert\ the\ entry\ to\ biblatex.=Shows fields having a successor in biblatex.\nFor instance, the publication month should be part of the date field.\nUse the Clean up Entries functionality to convert the entry to biblatex. +Shows\ fields\ having\ a\ successor\ in\ biblatex.\nFor\ instance,\ the\ publication\ month\ should\ be\ part\ of\ the\ date\ field.\nUse\ the\ Clean\ up\ Entries\ functionality\ to\ convert\ the\ entry\ to\ biblatex.=Shows fields having a successor in biblatex.\nFor instance, the publication month should be part of the date field.\nUse the Clean up Entries functionality to convert the entry to biblatex. No\ read\ status\ information=No read status information From f614cc0af37cbe5f0fc2ff92f2e90b724d8c23db Mon Sep 17 00:00:00 2001 From: Rishivardhan <96052865+rishivardhanmm@users.noreply.github.com> Date: Wed, 12 Mar 2025 18:55:58 +0530 Subject: [PATCH 5/6] Update CHANGELOG.md Co-authored-by: Subhramit Basu Bhowmick --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 087532c44e7..cfdd8d483dd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -49,7 +49,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We removed the obsolete Twitter link and added Mastodon and LinkedIn links in Help -> JabRef resources. [#12660](https://github.com/JabRef/jabref/issues/12660) - We improved the Check Integrity dialog entry interaction so that a single click focuses on the corresponding entry and a double-click both focuses on the entry and closes the dialog. [#12245](https://github.com/JabRef/jabref/issues/12245) - We improved journal abbreviation lookup with fuzzy matching to handle minor input errors and variations. [#12467](https://github.com/JabRef/jabref/issues/12467) -- We changed a text JabRef displayed "Cleanup entries" instead of "Clean up entries" [#12710](https://github.com/JabRef/jabref/issues/12710) +- We changed the phrase "Cleanup entries" to "Clean up entries". [#12710](https://github.com/JabRef/jabref/issues/12710) ### Fixed From 8505a3152b08f7e04fe1eee691da7c25d1e71d3c Mon Sep 17 00:00:00 2001 From: Rishivardhan Date: Wed, 12 Mar 2025 19:49:17 +0530 Subject: [PATCH 6/6] replacing "Cleanup entries" to "Clean up entries" --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cfdd8d483dd..fbf9b65de46 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -49,7 +49,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We removed the obsolete Twitter link and added Mastodon and LinkedIn links in Help -> JabRef resources. [#12660](https://github.com/JabRef/jabref/issues/12660) - We improved the Check Integrity dialog entry interaction so that a single click focuses on the corresponding entry and a double-click both focuses on the entry and closes the dialog. [#12245](https://github.com/JabRef/jabref/issues/12245) - We improved journal abbreviation lookup with fuzzy matching to handle minor input errors and variations. [#12467](https://github.com/JabRef/jabref/issues/12467) -- We changed the phrase "Cleanup entries" to "Clean up entries". [#12710](https://github.com/JabRef/jabref/issues/12710) +- We changed the phrase "Cleanup entries" to "Clean up entries". [#12703](https://github.com/JabRef/jabref/issues/12703) ### Fixed