Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Nov 5, 2025

With the modularization we got "jablib". Now, its time to offer it as "useful" library.

I tried to write some scripts in JBang, but the API of JabRef was less than OKish, so I refactored.

Aim for this PR:

  • Extract references from PDF
  • DOI to BibTeX --> follow-up PR

Additional Changes

IEEE as explicit rule-based parser available

grafik

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

InAnYan
InAnYan previously approved these changes Nov 6, 2025
@koppor koppor enabled auto-merge November 6, 2025 16:47
@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 6, 2025
@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label Nov 6, 2025
@koppor koppor added this pull request to the merge queue Nov 6, 2025
Merged via the queue into main with commit 0dc6dd7 Nov 6, 2025
52 checks passed
@koppor koppor deleted the add-jablib-examples branch November 6, 2025 22:08
return CitationSplitter.splitCitations(text)
.map(Unchecked.function(this::parsePlainCitation))
.flatMap(Optional::stream)
.collect(Collectors.toList());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.collect(Collectors.toList());
.toList();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, just in time 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow-up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge PR is tagged with that label will be merged if workflows are green component: jablib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants