-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Initial framework for jablib-examples #14233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- BibliographyFromPdfImporter is also an PdfImporter - importDatabase returns ParserResult (for consistency)
(and fix BibligraphyFromPdfImporter method use)
| return CitationSplitter.splitCitations(text) | ||
| .map(Unchecked.function(this::parsePlainCitation)) | ||
| .flatMap(Optional::stream) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .collect(Collectors.toList()); | |
| .toList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, just in time 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow-up :)
With the modularization we got "jablib". Now, its time to offer it as "useful" library.
I tried to write some scripts in JBang, but the API of JabRef was less than OKish, so I refactored.
Aim for this PR:
DOI to BibTeX--> follow-up PRAdditional Changes
IEEE as explicit rule-based parser available
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)