Skip to content

Commit 07493a9

Browse files
authored
Added contribution documentation to describe running workflows thru github (#530)
1 parent b6d5755 commit 07493a9

File tree

3 files changed

+20
-21
lines changed

3 files changed

+20
-21
lines changed

.github/workflows/check-links.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Check external href links in the documentation
1+
name: Check links
22

33
on:
44
push:
126 KB
Loading

en/contributing/how-to-improve-the-help-page.md

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -54,36 +54,35 @@ That's it! The JabRef team will review your changes and publish them on [docs.ja
5454

5555
To edit more than one file at a time, add screenshots, and for other more advanced changes, we recommend that you checkout this repository locally and create a Pull Request of your changes using the standard git and GitHub workflow.
5656

57-
### Tables
57+
### CI
5858

59-
The best way to enter tables is to use this [Table Generator](http://www.tablesgenerator.com/markdown\_tables) for Markdown. It has the nice feature to generate markdown tables from different sources, e.g. you can directly copy the table from a spreadsheet or upload a csv file. Just copy and paste the generated markdown into the documentation.
59+
Two CI jobs (called "workflows" in GitHub terminology) are triggered each time you push or pull request.
6060

61-
### How to regenerate `SUMMARY.md` from scratch
61+
- Lint workflow checks for minor Markdown formatting style issues.
6262

63-
Use <https://github.com/koppor/gitbook-summary-generator>.
63+
- Check links workflow checks for broken links, e.g. to images or external resources.
64+
65+
On PRs, you are able to view the results directly on the PR (though you have to wait for a maintainer to approve running the workflow). You can also view the results on the local fork of the repo that you pushed to (which you are recommended to check first so you can fix mistakes before the maintainer has to look at it).
66+
67+
On your local fork, you can check the results of the workflows in the Actions tab > All actions panel on Github as shown below. Click on a specific workflow and its run to check the results.
6468

65-
### How to find broken links
69+
![Actions tab on Github](../.gitbook/assets/workflow-check-results.png)
6670

67-
1. Install [markdown-link-check](https://github.com/tcort/markdown-link-check): `npm install -g markdown-link check`
68-
2. `find . -name \*.md -exec markdown-link-check -qq {} \; > bad-links.txt`
71+
### Notes on links workflow
6972

70-
### How to find Markdown errors
73+
Links to external resources that aren't essential should be added to `.lycheeignore`. Resources can change URL or be taken down, and it isn't the best use of contributor resources to constantly keep fixing them, so try to spare us the headache!
7174

72-
You can use the [markdown-lint docker image](https://github.com/marketplace/actions/markdown-linting-action):
75+
Note that check links may fail on links which you did not modify in your changes, in which case you can ignore them. Just do make sure that you don't introduce any additional broken links.
7376

74-
```shell
75-
docker run --rm \
76-
-v "$(pwd):/tmp/check" \
77-
-e INPUT_CONFIG=/tmp/check/.markdownlint.yml \
78-
avtodev/markdown-lint:v1 \
79-
/tmp/check/en
80-
```
77+
TEMPORARY NOTE: until [issue #533](https://github.com/JabRef/user-documentation/issues/533) is fixed, you will actually find a _lot_ of broken links.
8178

82-
Alternatively, you can run the GitHub Lint workflow:
79+
### Tables
80+
81+
The best way to enter tables is to use this [Table Generator](http://www.tablesgenerator.com/markdown\_tables) for Markdown. It has the nice feature to generate markdown tables from different sources, e.g. you can directly copy the table from a spreadsheet or upload a csv file. Just copy and paste the generated markdown into the documentation.
8382

84-
```shell
85-
act --rm --platform ubuntu-latest=fwilhe2/act-runner:latest -W .github/workflows/lint.yaml
86-
```
83+
### How to regenerate `SUMMARY.md` from scratch
84+
85+
Use <https://github.com/koppor/gitbook-summary-generator>.
8786

8887
### How to rename files
8988

0 commit comments

Comments
 (0)