Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented May 30, 2025

With JabRef/jabref#13189 and eirikb/gg#112 it's now even more easy to try out things:

.\gg.cmd just run-pr 13182

@koppor koppor requested a review from subhramit May 30, 2025 10:43
@koppor
Copy link
Member Author

koppor commented May 30, 2025

Users need to manually type 1 and enter for trust.

Should we change that to

.\gg.cmd jbang trust add https://github.com/JabRef/jabref

?

@subhramit
Copy link
Member

Users need to manually type 1 and enter for trust.

2, you mean? Here, we mentioned 2 (otherwise this recurs I guess)

Should we change that to

.\gg.cmd jbang trust add https://github.com/JabRef/jabref

?

Yes, this reduces one step - we should.

@koppor
Copy link
Member Author

koppor commented May 30, 2025

Yes, this reduces one step - we should.

However, it adds one step - but maybe the text is more easy to write?

@koppor
Copy link
Member Author

koppor commented May 30, 2025

Users need to manually type 1 and enter for trust.
2, you mean? Here, we mentioned 2 (otherwise this recurs I guess)

I meant there JabRef/blog.jabref.org#115

2. JBang will ask for trust - please trust the script with <kbd>2</kbd> and then <kbd>Enter</kbd>

@subhramit
Copy link
Member

Yes, this reduces one step - we should.

However, it adds one step - but maybe the text is more easy to write?

Oh I misinterpreted this to be the initial command. No, trusting with 2 and enter is fine then

@koppor
Copy link
Member Author

koppor commented May 30, 2025

Oh I misinterpreted this to be the initial command. No, trusting with 2 and enter is fine then

Oh, I updated it to explicit "trust" at JabRef/blog.jabref.org#115

Let's see, what you like more :)

Since JBang needs some seconds to start initially and has a timeout of 30 seconds for the answer, I sometimes miss that...

@koppor koppor marked this pull request as draft May 30, 2025 21:01
@koppor
Copy link
Member Author

koppor commented May 30, 2025

First, we should get JabRef/blog.jabref.org#115 ready, then we can "finish" this part of the documentation.

@subhramit
Copy link
Member

Let's see, what you like more :)

So, I liked the old one more because when prompted, I as a user, even without explicit instruction would choose to trust. In the explicit instruction too, it is more of a "follow-through" sub-step when I am told to press 2 and enter. Adding the trust command is a new step in itself.
But this at the end is just nitpick, another user can like the other more so I would say good to go.

@koppor koppor requested a review from subhramit May 31, 2025 20:37
@koppor koppor marked this pull request as ready for review May 31, 2025 20:37
@subhramit subhramit merged commit e73b68e into main May 31, 2025
5 checks passed
@subhramit subhramit deleted the koppor-patch-2 branch May 31, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants