Refactor diagnostics to use centralized constants

Refactored `AnalyzerDiagnostics` and `SourceGeneratorDiagnostics` to use constants from the `Constants` class for diagnostic IDs and titles, reducing duplication and improving maintainability.

Added new constants to the `Constants` class for diagnostic IDs and titles, including:
- `OldLocalizationApiUsedId` and `OldLocalizationApiUsedTitle`
- `CouldNotFindResourceDictionariesId`
- `LocalizationKeyUnusedId`
- `EnumFieldLocalizationKeyValueInvalidId`

Updated the `SuppressWarning` constant to dynamically reference `OldLocalizationApiUsedId` and `OldLocalizationApiUsedTitle`.

Replaced hardcoded diagnostic strings with centralized constants, ensuring consistency and simplifying future updates.

Author: Jack251970

Localization/Editor.Localization.Analyzers/AnalyzerDiagnostics.cs

@@ -6,8 +6,8 @@ namespace Editor.Localization.Analyzers
     public static class AnalyzerDiagnostics
     {
         public static readonly DiagnosticDescriptor OldLocalizationApiUsed = new DiagnosticDescriptor(
-            "FLAN0001",
-            "Old localization API used",
+            Constants.OldLocalizationApiUsedId,
+            Constants.OldLocalizationApiUsedTitle,
             $"Use `{Constants.ClassName}.{{0}}({{1}})` instead",
             "Localization",
             DiagnosticSeverity.Warning,

Localization/Editor.Localization.Shared/Constants.cs

@@ -4,6 +4,12 @@ namespace Editor.Localization.Shared
 {
     public static class Constants
     {
+        public const string OldLocalizationApiUsedId = "FLAN0001";
+        public const string OldLocalizationApiUsedTitle = "Old localization API used";
+        public const string CouldNotFindResourceDictionariesId = "FLSG0001";
+        public const string LocalizationKeyUnusedId = "FLSG0002";
+        public const string EnumFieldLocalizationKeyValueInvalidId = "FLSG0003";
+
         public const string DefaultNamespace = "Editor";
         public const string ClassName = "Localize";
         public const string SystemPrefixUri = "http://schemas.microsoft.com/winfx/2006/xaml";
@@ -23,7 +29,7 @@ public static class Constants
         public const string EnumLocalizeKeyAttributeName = "EnumLocalizeKeyAttribute";
         public const string EnumLocalizeValueAttributeName = "EnumLocalizeValueAttribute";
         public const string Internationalization = "Internationalization";
-        public const string SuppressWarning = "#pragma warning disable FLAN0001 // Old localization API used";
+        public static readonly string SuppressWarning = $"#pragma warning disable {OldLocalizationApiUsedId} // {OldLocalizationApiUsedTitle}";
         // Regex to match file paths ending with /Languages/en.axaml on Linux & MacOS or \Languages\en.axaml on Windows
         public static readonly Regex LanguagesAxamlRegex = new Regex(@"[\\/]+Languages[\\/]en\.axaml$", RegexOptions.IgnoreCase);
         public static readonly string[] OldLocalizationClasses = { "Internationalization" };

Localization/Editor.Localization.SourceGenerators/SourceGeneratorDiagnostics.cs

@@ -6,7 +6,7 @@ namespace Editor.Localization.SourceGenerators
     public static class SourceGeneratorDiagnostics
     {
         public static readonly DiagnosticDescriptor CouldNotFindResourceDictionaries = new DiagnosticDescriptor(
-            "FLSG0001",
+            Constants.CouldNotFindResourceDictionariesId,
             "Could not find resource dictionaries",
             "Could not find resource dictionaries. There must be a `en.axaml` file under `Language` folder.",
             "Localization",
@@ -15,7 +15,7 @@ public static class SourceGeneratorDiagnostics
         );
 
         public static readonly DiagnosticDescriptor LocalizationKeyUnused = new DiagnosticDescriptor(
-            "FLSG0002",
+            Constants.LocalizationKeyUnusedId,
             "Localization key is unused",
             $"Method `{Constants.ClassName}.{{0}}` is never used",
             "Localization",
@@ -24,7 +24,7 @@ public static class SourceGeneratorDiagnostics
         );
 
         public static readonly DiagnosticDescriptor EnumFieldLocalizationKeyValueInvalid = new DiagnosticDescriptor(
-            "FLSG0003",
+            Constants.EnumFieldLocalizationKeyValueInvalidId,
             "Enum field localization key and value invalid",
             $"Enum field `{{0}}` does not have a valid localization key or value",
             "Localization",