Merge pull request #60 from Jackpieking/F15

fix(F15): Refactor f15 at some logic

Author: Jackpieking

Src/Core/F15/BusinessLogic/F15Service.cs

@@ -39,7 +39,7 @@ CancellationToken ct
                     Id = request.TodoTaskId,
                     Content = taskDetail.Content,
                     DueDate = taskDetail.DueDate,
-                    IsFinished = taskDetail.IsFinished,
+                    IsCompleted = taskDetail.IsCompleted,
                     IsImportant = taskDetail.IsImportant,
                     IsInMyDay = taskDetail.IsInMyDay,
                     Note = taskDetail.Note,

Src/Core/F15/DataAccess/F15Repository.cs

@@ -24,29 +24,18 @@ public Task<bool> DoesTodoTaskExistAsync(long taskId, CancellationToken ct)
 
     public async Task<F15TodoTaskModel> GetTaskDetailByIdAsync(long taskId, CancellationToken ct)
     {
-        var foundTask = await _appContext
+        return await _appContext
             .Set<TodoTaskEntity>()
-            .AsNoTracking()
             .Where(entity => entity.Id == taskId)
-            .Select(entity => new TodoTaskEntity
+            .Select(entity => new F15TodoTaskModel
             {
                 Content = entity.Content,
                 DueDate = entity.DueDate,
                 IsInMyDay = entity.IsInMyDay,
                 IsImportant = entity.IsImportant,
                 Note = entity.Note,
-                IsFinished = entity.IsFinished,
+                IsCompleted = entity.IsFinished,
             })
             .FirstOrDefaultAsync(ct);
-
-        return new()
-        {
-            Content = foundTask.Content,
-            DueDate = foundTask.DueDate,
-            IsInMyDay = foundTask.IsInMyDay,
-            IsImportant = foundTask.IsImportant,
-            Note = foundTask.Note,
-            IsFinished = foundTask.IsFinished,
-        };
     }
 }

Src/Core/F15/Mapper/F15HttpResponseMapper.cs

@@ -35,7 +35,7 @@ private static void Init()
                             Id = appResponse.Body.TodoTask.Id,
                             Content = appResponse.Body.TodoTask.Content,
                             DueDate = appResponse.Body.TodoTask.DueDate,
-                            IsFinished = appResponse.Body.TodoTask.IsFinished,
+                            IsCompleted = appResponse.Body.TodoTask.IsCompleted,
                             IsImportant = appResponse.Body.TodoTask.IsImportant,
                             IsInMyDay = appResponse.Body.TodoTask.IsInMyDay,
                             Note = appResponse.Body.TodoTask.Note,

Src/Core/F15/Models/F15AppResponseModel.cs

@@ -28,7 +28,7 @@ public sealed class TodoTaskModel
 
             public string Note { get; set; }
 
-            public bool IsFinished { get; set; }
+            public bool IsCompleted { get; set; }
         }
     }
 }

Src/Core/F15/Models/F15TodoTaskModel.cs

@@ -16,5 +16,5 @@ public sealed class F15TodoTaskModel
 
     public string Note { get; set; }
 
-    public bool IsFinished { get; set; }
+    public bool IsCompleted { get; set; }
 }

Src/Core/F15/Presentation/F15Response.cs

@@ -30,7 +30,7 @@ public sealed class TodoTaskDto
 
             public string Note { get; set; }
 
-            public bool IsFinished { get; set; }
+            public bool IsCompleted { get; set; }
         }
     }
 }