feat: migrate from mypy/pyright to ty type checker (#105)

Co-authored-by: Claude <[email protected]>

Author: JacobCoffee

.github/workflows/ci.yml

@@ -10,29 +10,47 @@ jobs:
   validate:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Install uv
-        uses: astral-sh/setup-uv@v3
+        uses: astral-sh/setup-uv@v6
+        with:
+          enable-cache: true
 
       - name: Set up Python
-        run: uv python install 3.12
+        uses: actions/setup-python@v6
+        with:
+          python-version-file: "pyproject.toml"
 
       - name: Create virtual environment
         run: uv sync --all-extras --dev
 
+      - name: Run ruff lint
+        uses: astral-sh/ruff-action@v3
+
+      - name: Run ruff format check
+        uses: astral-sh/ruff-action@v3
+        with:
+          args: "format --check --diff"
+
+      - name: Run ty type checker
+        uses: JacobCoffee/[email protected]
+        with:
+          version: '0.0.1a26'
+          args: 'check'
+
       - name: Install prek hooks
         run: uv run prek install
 
       - name: Load cached prek Dependencies
         id: cached-prek-dependencies
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ~/.cache/prek/
           key: prek|${{ env.pythonLocation }}|${{ hashFiles('.prek-config.yaml') }}
 
-      - name: Execute prek
-        run: uv run prek run --show-diff-on-failure --color=always --all-files
+      - name: Run other prek hooks
+        run: uv run prek run --show-diff-on-failure --color=always --all-files --hook-stage manual
 
   test:
     runs-on: ubuntu-latest
@@ -44,13 +62,17 @@ jobs:
         shell: bash
     steps:
       - name: Check out repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Install uv
-        uses: astral-sh/setup-uv@v3
+        uses: astral-sh/setup-uv@v6
+        with:
+          enable-cache: true
 
       - name: Set up Python
-        run: uv python install 3.12
+        uses: actions/setup-python@v6
+        with:
+          python-version-file: "pyproject.toml"
 
       - name: Create virtual environment
         run: uv sync --all-extras --dev
@@ -70,13 +92,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Install uv
-        uses: astral-sh/setup-uv@v3
+        uses: astral-sh/setup-uv@v6
+        with:
+          enable-cache: true
 
       - name: Set up Python
-        run: uv python install 3.12
+        uses: actions/setup-python@v6
+        with:
+          python-version-file: "pyproject.toml"
 
       - name: Create virtual environment
         run: uv sync --all-extras --dev

.pre-commit-config.yaml

@@ -87,62 +87,14 @@ repos:
   #             polyfactory,
   #             discord-py,
   #           ]
-  - repo: https://github.com/RobertCraigie/pyright-python
-    rev: v1.1.407
+  - repo: local
     hooks:
-      - id: pyright
-        additional_dependencies:
-          [
-            advanced_alchemy,
-            annotated_types,
-            anyio>=3,
-            asyncpg,
-            asyncpg_stubs,
-            brotli,
-            click,
-            cryptography,
-            fast-query-parsers>=1.0.2,
-            fsspec,
-            greenlet,
-            httpx>=0.22,
-            httpx_sse,
-            hypothesis,
-            jinja2>=3.1.2,
-            jsbeautifier,
-            mako>=1.2.4,
-            msgspec>=0.18.2,
-            multidict>=6.0.2,
-            opentelemetry-instrumentation-asgi,
-            opentelemetry-sdk,
-            polyfactory>=2.6.3,
-            prometheus_client,
-            "pydantic>=2",
-            pydantic-extra-types,
-            pydantic-settings,
-            pytest,
-            pytest-asyncio,
-            pytest-cov,
-            pytest-lazy-fixture,
-            pytest-mock,
-            pytest-rerunfailures,
-            pytest-timeout,
-            python-dotenv,
-            pyyaml,
-            rich-click,
-            rich>=13.0.0,
-            structlog,
-            types-pytest-lazy-fixture,
-            types-pyyaml,
-            typing-extensions,
-            "uvicorn[standard]",
-            uvloop>=0.18.0,
-            asyncpg,
-            "litestar[cli,structlog,standard]",
-            types-click,
-            asyncpg-stubs,
-            polyfactory,
-            discord-py,
-          ]
+      - id: ty
+        name: ty
+        entry: uvx ty check
+        language: system
+        types: [python]
+        pass_filenames: false
   - repo: https://github.com/sphinx-contrib/sphinx-lint
     rev: "v1.0.2"
     hooks:

.prek-config.yaml

@@ -87,59 +87,14 @@ repos:
   #             polyfactory,
   #             discord-py,
   #           ]
-  - repo: https://github.com/RobertCraigie/pyright-python
-    rev: v1.1.407
+  - repo: local
     hooks:
-      - id: pyright
-        additional_dependencies:
-          [
-            advanced_alchemy,
-            annotated_types,
-            anyio>=3,
-            asyncpg,
-            asyncpg-stubs,
-            brotli,
-            click,
-            cryptography,
-            fast-query-parsers>=1.0.2,
-            fsspec,
-            greenlet,
-            httpx>=0.22,
-            httpx_sse,
-            hypothesis,
-            jinja2>=3.1.2,
-            jsbeautifier,
-            mako>=1.2.4,
-            msgspec>=0.18.2,
-            multidict>=6.0.2,
-            opentelemetry-instrumentation-asgi,
-            opentelemetry-sdk,
-            polyfactory>=2.6.3,
-            prometheus_client,
-            "pydantic>=2",
-            pydantic-extra-types,
-            pydantic-settings,
-            pytest,
-            pytest-asyncio,
-            pytest-cov,
-            pytest-lazy-fixture,
-            pytest-mock,
-            pytest-rerunfailures,
-            pytest-timeout,
-            python-dotenv,
-            pyyaml,
-            rich-click,
-            rich>=13.0.0,
-            structlog,
-            types-pytest-lazy-fixture,
-            types-pyyaml,
-            typing-extensions,
-            "uvicorn[standard]",
-            uvloop>=0.18.0,
-            "litestar[cli,structlog,standard]",
-            types-click,
-            discord-py,
-          ]
+      - id: ty
+        name: ty
+        entry: uvx ty check
+        language: system
+        types: [python]
+        pass_filenames: false
   - repo: https://github.com/sphinx-contrib/sphinx-lint
     rev: "v1.0.2"
     hooks:

CONTRIBUTING.rst

@@ -32,7 +32,7 @@ Guidelines for writing code
 ----------------------------
 
 - All code should be fully `typed <https://peps.python.org/pep-0484/>`_. This is enforced via
-  `mypy <https://mypy.readthedocs.io/en/stable/>`_.
+  `ty <https://github.com/astral-sh/ty>`_.
 - All code should be tested. This is enforced via `pytest <https://docs.pytest.org/en/stable/>`_.
 - All code should be properly formatted. This is enforced via `black <https://black.readthedocs.io/en/stable/>`_ and `Ruff <https://beta.ruff.rs/docs/>`_.
 

Makefile

@@ -53,7 +53,7 @@ install-frontend: ## Install the frontend dependencies
 .PHONY: install-backend
 install-backend: ## Install the backend dependencies
 	@echo "=> Installing backend dependencies"
-	@$(UV) venv && $(UV) pip install --quiet -U wheel setuptools cython mypy pip
+	@$(UV) venv && $(UV) pip install --quiet -U wheel setuptools cython pip
 	@$(UV) sync --all-extras --force-reinstall --dev
 	@echo "=> Backend dependencies installed"
 
@@ -106,6 +106,9 @@ ruff-check: ## Runs Ruff without changing files
 ruff-noqa: ## Runs Ruff, adding noqa comments to disable warnings
 	@$(UV) run --no-sync ruff check . --add-noqa
 
+type-check: ## Run ty type checker
+	@$(UV) run --no-sync ty check
+
 test:  ## Run the tests
 	@$(UV) run --no-sync pytest tests
 
@@ -176,7 +179,6 @@ clean: ## Autogenerated File Cleanup
 	@rm -rf .pytest_cache
 	@rm -rf tests/.pytest_cache
 	@rm -rf tests/**/.pytest_cache
-	@rm -rf .mypy_cache
 	$(MAKE) docs-clean
 
 destroy: ## Destroy the virtual environment

byte_bot/byte/plugins/custom/litestar.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 import datetime
-from typing import Self
 
 from dateutil.zoneinfo import gettz
 from discord import Embed, EntityType, Interaction, Message, Object, PrivacyLevel
@@ -26,21 +25,21 @@
 class GitHubIssue(Modal, title="Create GitHub Issue"):
     """Modal for GitHub issue creation."""
 
-    title_ = TextInput[Self](label="title", placeholder="Title")
-    description = TextInput[Self](
+    title_ = TextInput(label="title", placeholder="Title")
+    description = TextInput(
         label="Description",
         style=TextStyle.paragraph,
         placeholder="Please enter an description of the bug you are encountering.",
     )
-    mcve = TextInput[Self](
+    mcve = TextInput(
         label="MCVE",
         style=TextStyle.paragraph,
         placeholder="Please provide a minimal, complete, and verifiable example of the issue.",
     )
-    logs = TextInput[Self](
+    logs = TextInput(
         label="Logs", style=TextStyle.paragraph, placeholder="Please copy and paste any relevant log output."
     )
-    version = TextInput[Self](
+    version = TextInput(
         label="Litestar Version", placeholder="What version of Litestar are you using when encountering this issue?"
     )
 
@@ -180,6 +179,10 @@ async def schedule_office_hours(self, interaction: Interaction, delay: int | Non
             interaction: Interaction object.
             delay: Optional. Number of weeks to delay the event.
         """
+        if interaction.guild is None:
+            await interaction.response.send_message("This command can only be used in a guild.", ephemeral=True)
+            return
+
         now_cst = datetime.datetime.now(gettz("America/Chicago"))
         start_dt, end_dt = get_next_friday(now_cst, delay)
         existing_events = interaction.guild.scheduled_events

byte_bot/byte/plugins/github.py

@@ -2,8 +2,6 @@
 
 from __future__ import annotations
 
-from typing import Self
-
 from discord import Interaction, Message, TextStyle, app_commands
 from discord.ext.commands import Bot, Cog
 from discord.ui import Modal, TextInput
@@ -18,21 +16,21 @@
 class GitHubIssue(Modal, title="Create GitHub Issue"):
     """Modal for GitHub issue creation."""
 
-    title_ = TextInput[Self](label="title", placeholder="Title")
-    description = TextInput[Self](
+    title_ = TextInput(label="title", placeholder="Title")
+    description = TextInput(
         label="Description",
         style=TextStyle.paragraph,
         placeholder="Please enter an description of the bug you are encountering.",
     )
-    mcve = TextInput[Self](
+    mcve = TextInput(
         label="MCVE",
         style=TextStyle.paragraph,
         placeholder="Please provide a minimal, complete, and verifiable example of the issue.",
     )
-    logs = TextInput[Self](
+    logs = TextInput(
         label="Logs", style=TextStyle.paragraph, placeholder="Please copy and paste any relevant log output."
     )
-    version = TextInput[Self](
+    version = TextInput(
         label="Project Version", placeholder="What version of the project are you using when encountering this issue?"
     )
 

byte_bot/byte/views/abstract_views.py

@@ -74,7 +74,7 @@ async def delete_button_callback(self, interaction: Interaction) -> None:
         Args:
             interaction: Interaction object.
         """
-        if await self.delete_interaction_check(interaction):
+        if await self.delete_interaction_check(interaction) and interaction.message is not None:
             await interaction.message.delete()
 
     async def learn_more_button_callback(self, interaction: Interaction) -> None:

byte_bot/byte/views/config.py

@@ -29,7 +29,8 @@ async def callback(self, interaction: Interaction) -> None:
             interaction: Interaction object.
         """
         await interaction.response.send_message("Configuration complete!", ephemeral=True)
-        self.view.stop()
+        if self.view is not None:
+            self.view.stop()
 
 
 class BackButton(Button):
@@ -63,7 +64,8 @@ async def callback(self, interaction: Interaction) -> None:
             interaction: Interaction object.
         """
         await interaction.response.send_message("Configuration cancelled.", ephemeral=True)
-        self.view.stop()
+        if self.view is not None:
+            self.view.stop()
 
 
 class ConfigSelect(Select):