Skip to content

Commit a1fa62f

Browse files
authored
fix: resolve integration test transaction lifecycle issues (#125)
1 parent 8617c06 commit a1fa62f

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

tests/integration/test_api_endpoints.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,6 @@ async def test_full_guild_with_all_configs_lifecycle(
296296
# DELETE guild (should cascade)
297297
await db_session.delete(guild)
298298
await db_session.flush()
299-
await db_session.commit()
300299

301300
# VERIFY cascade deleted all configs
302301
guild_check = await db_session.execute(select(Guild).where(Guild.guild_id == 9999))
@@ -333,7 +332,6 @@ async def test_guild_with_multiple_sotags_and_users(
333332
db_session.add(so_tag)
334333

335334
await db_session.flush()
336-
await db_session.commit()
337335

338336
# Verify all tags exist
339337
result = await db_session.execute(select(SOTagsConfig).where(SOTagsConfig.guild_id == 8888))
@@ -489,10 +487,9 @@ async def test_pagination_offset_and_limit(
489487
db_session.add(guild)
490488

491489
await db_session.flush()
492-
await db_session.commit()
493490

494491
# Test with explicit limit
495-
response = await api_client.get("/api/guilds/list?pageSize=5")
492+
response = await api_client.get("/api/guilds/list?limit=5")
496493
if response.status_code == HTTP_200_OK:
497494
data = response.json()
498495
# Should respect page size limit
@@ -528,7 +525,6 @@ async def test_duplicate_guild_id_rejected(
528525
guild1 = Guild(guild_id=5555, guild_name="First Guild")
529526
db_session.add(guild1)
530527
await db_session.flush()
531-
await db_session.commit()
532528

533529
# Try to create duplicate - should raise integrity error
534530
from sqlalchemy.exc import IntegrityError
@@ -539,8 +535,6 @@ async def test_duplicate_guild_id_rejected(
539535
with pytest.raises(IntegrityError):
540536
await db_session.flush()
541537

542-
await db_session.rollback()
543-
544538
async def test_foreign_key_constraint_enforced(
545539
self,
546540
db_session: AsyncSession,
@@ -597,12 +591,10 @@ async def test_cascade_delete_all_related_configs(
597591

598592
db_session.add_all([github, forum, so_tag])
599593
await db_session.flush()
600-
await db_session.commit()
601594

602595
# Delete guild
603596
await db_session.delete(guild)
604597
await db_session.flush()
605-
await db_session.commit()
606598

607599
# Verify all configs deleted
608600
github_check = await db_session.execute(select(GitHubConfig).where(GitHubConfig.guild_id == 4444))

0 commit comments

Comments
 (0)