merge: Phase 3.4 bot service comprehensive tests (92% coverage)

Merged 12 commits adding 165+ tests for bot service:
- Forums view tests for 96.77% coverage (32 tests)
- Forums, astral, python plugin tests at 100% (64 tests)
- Utils tests with subprocess/HTTP mocking at 100% (67 tests)
- Custom plugins (litestar) at 100% (21 tests)
- Bot lifecycle and event handlers at 100% (16 tests)
- All plugin edge cases and error handling (60+ tests)

Coverage: 79.59% → ~92% (+12.41%)
Total bot tests: 305 → 470 (+165, 54% increase)
Plugin coverage: 99.59% (near-perfect)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: JacobCoffee

pyproject.toml

@@ -39,6 +39,8 @@ dev = [
     "sourcery>=1.14.0",
     "ty>=0.0.1a26",
     "aiosqlite>=0.21.0",
+    "respx>=0.22.0",
+    "ruff>=0.14.6",
 ]
 
 [tool.codespell]

services/bot/src/byte_bot/lib/settings.py

@@ -26,7 +26,7 @@
 
 DEFAULT_MODULE_NAME: str = "byte_bot"
 BASE_DIR: Final = module_to_os_path(DEFAULT_MODULE_NAME)
-PLUGINS_DIR: Final = module_to_os_path("byte_bot.byte.plugins")
+PLUGINS_DIR: Final = module_to_os_path("byte_bot.plugins")
 
 
 class DiscordSettings(BaseSettings):

tests/conftest.py

@@ -2,18 +2,45 @@
 
 from __future__ import annotations
 
+import os
 from collections.abc import AsyncGenerator
 from typing import TYPE_CHECKING
 
 import pytest
 from advanced_alchemy.base import UUIDAuditBase
 from sqlalchemy.ext.asyncio import AsyncEngine, AsyncSession, async_sessionmaker, create_async_engine
 
+# Set required environment variables for bot tests BEFORE dotenv loads
+# These must be set before importing bot modules
+# BotSettings uses BOT_ prefix with case_sensitive=True, so field names must match exactly
+os.environ["BOT_discord_token"] = "test_token_for_pytest"
+os.environ["BOT_discord_dev_guild_id"] = "123456789"
+os.environ["BOT_discord_dev_user_id"] = "987654321"
+
+# Also set DISCORD_ prefix for DiscordSettings (used in settings.py)
+# Use assignment (not setdefault) to override .env values
+os.environ["DISCORD_TOKEN"] = "test_token_for_pytest"
+os.environ["DISCORD_DEV_GUILD_ID"] = "123456789"
+os.environ["DISCORD_DEV_USER_ID"] = "987654321"
+
 from tests.fixtures.api_fixtures import (
     api_app,
     api_client,
     mock_db_session,
 )
+from tests.fixtures.bot_fixtures import (
+    mock_api_client,
+    mock_api_responses,
+    mock_bot,
+    mock_channel,
+    mock_context,
+    mock_guild,
+    mock_interaction,
+    mock_member,
+    mock_message,
+    mock_role,
+    mock_user,
+)
 from tests.fixtures.db_fixtures import (
     create_sample_forum_config,
     create_sample_github_config,
@@ -33,7 +60,18 @@
     "async_engine",
     "async_session",
     "db_session",
+    "mock_api_client",
+    "mock_api_responses",
+    "mock_bot",
+    "mock_channel",
+    "mock_context",
     "mock_db_session",
+    "mock_guild",
+    "mock_interaction",
+    "mock_member",
+    "mock_message",
+    "mock_role",
+    "mock_user",
     "sample_forum_config",
     "sample_github_config",
     "sample_guild",

tests/fixtures/bot_fixtures.py

@@ -0,0 +1,303 @@
+"""Test fixtures for bot service testing."""
+
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+from unittest.mock import AsyncMock, MagicMock
+from uuid import uuid4
+
+import pytest
+import respx
+from httpx import Response
+
+if TYPE_CHECKING:
+    from discord import Guild, Interaction, Member, Message, Role, TextChannel, User
+    from discord.ext.commands import Bot, Context
+
+__all__ = (
+    "mock_api_client",
+    "mock_api_responses",
+    "mock_bot",
+    "mock_channel",
+    "mock_context",
+    "mock_guild",
+    "mock_interaction",
+    "mock_member",
+    "mock_message",
+    "mock_role",
+    "mock_user",
+)
+
+
+@pytest.fixture
+def mock_bot() -> Bot:
+    """Create a mock discord.ext.commands.Bot.
+
+    Returns:
+        Mock bot instance with common attributes.
+    """
+    bot = MagicMock()
+    bot.user = MagicMock()
+    bot.user.id = 123456789
+    bot.user.name = "ByteBot"
+    bot.user.discriminator = "0000"
+    bot.is_owner = AsyncMock(return_value=False)
+    bot.load_extension = AsyncMock()
+    bot.tree = MagicMock()
+    bot.tree.sync = AsyncMock()
+    bot.tree.copy_global_to = MagicMock()
+    return bot
+
+
+@pytest.fixture
+def mock_user() -> User:
+    """Create a mock discord.User.
+
+    Returns:
+        Mock user instance.
+    """
+    user = MagicMock()
+    user.id = 987654321
+    user.name = "TestUser"
+    user.discriminator = "1234"
+    user.mention = "<@987654321>"
+    user.avatar = MagicMock()
+    user.avatar.url = "https://cdn.discordapp.com/avatars/987654321/test.png"
+    user.bot = False
+    return user
+
+
+@pytest.fixture
+def mock_role() -> Role:
+    """Create a mock discord.Role.
+
+    Returns:
+        Mock role instance.
+    """
+    role = MagicMock()
+    role.id = 111111111
+    role.name = "TestRole"
+    role.mention = "<@&111111111>"
+    return role
+
+
+@pytest.fixture
+def mock_member(mock_user: User, mock_role: Role) -> Member:
+    """Create a mock discord.Member.
+
+    Args:
+        mock_user: Mock user fixture
+        mock_role: Mock role fixture
+
+    Returns:
+        Mock member instance.
+    """
+    member = MagicMock()
+    member.id = mock_user.id
+    member.name = mock_user.name
+    member.discriminator = mock_user.discriminator
+    member.mention = mock_user.mention
+    member.avatar = mock_user.avatar
+    member.bot = False
+    member.roles = [mock_role]
+    member.guild_permissions = MagicMock()
+    member.guild_permissions.administrator = False
+    member.send = AsyncMock()
+    return member
+
+
+@pytest.fixture
+def mock_guild(mock_member: Member) -> Guild:
+    """Create a mock discord.Guild.
+
+    Args:
+        mock_member: Mock member fixture
+
+    Returns:
+        Mock guild instance.
+    """
+    guild = MagicMock()
+    guild.id = 555555555
+    guild.name = "Test Guild"
+    guild.get_member = MagicMock(return_value=mock_member)
+    guild.owner_id = 999999999
+    return guild
+
+
+@pytest.fixture
+def mock_channel() -> TextChannel:
+    """Create a mock discord.TextChannel.
+
+    Returns:
+        Mock text channel instance.
+    """
+    channel = MagicMock()
+    channel.id = 777777777
+    channel.name = "test-channel"
+    channel.mention = "<#777777777>"
+    channel.send = AsyncMock()
+    return channel
+
+
+@pytest.fixture
+def mock_message(mock_user: User, mock_channel: TextChannel, mock_guild: Guild) -> Message:
+    """Create a mock discord.Message.
+
+    Args:
+        mock_user: Mock user fixture
+        mock_channel: Mock channel fixture
+        mock_guild: Mock guild fixture
+
+    Returns:
+        Mock message instance.
+    """
+    message = MagicMock()
+    message.id = 888888888
+    message.author = mock_user
+    message.channel = mock_channel
+    message.guild = mock_guild
+    message.content = "!test command"
+    message.jump_url = f"https://discord.com/channels/{mock_guild.id}/{mock_channel.id}/{message.id}"
+    message.created_at = MagicMock()
+    message.created_at.strftime = MagicMock(return_value="2024-01-01 12:00:00")
+    message.delete = AsyncMock()
+    return message
+
+
+@pytest.fixture
+def mock_interaction(mock_user: User, mock_guild: Guild, mock_channel: TextChannel) -> Interaction:
+    """Create a mock discord.Interaction.
+
+    Args:
+        mock_user: Mock user fixture
+        mock_guild: Mock guild fixture
+        mock_channel: Mock channel fixture
+
+    Returns:
+        Mock interaction instance.
+    """
+    interaction = MagicMock()
+    interaction.user = mock_user
+    interaction.guild = mock_guild
+    interaction.channel = mock_channel
+    interaction.message = None
+    interaction.response = MagicMock()
+    interaction.response.send_message = AsyncMock()
+    interaction.response.defer = AsyncMock()
+    return interaction
+
+
+@pytest.fixture
+def mock_context(
+    mock_bot: Bot,
+    mock_user: User,
+    mock_guild: Guild,
+    mock_channel: TextChannel,
+    mock_message: Message,
+) -> Context:
+    """Create a mock discord.ext.commands.Context.
+
+    Args:
+        mock_bot: Mock bot fixture
+        mock_user: Mock user fixture
+        mock_guild: Mock guild fixture
+        mock_channel: Mock channel fixture
+        mock_message: Mock message fixture
+
+    Returns:
+        Mock context instance.
+    """
+    context = MagicMock()
+    context.bot = mock_bot
+    context.author = mock_user
+    context.guild = mock_guild
+    context.channel = mock_channel
+    context.message = mock_message
+    context.command = MagicMock()
+    context.command.name = "test"
+    context.interaction = None
+    context.send = AsyncMock()
+    return context
+
+
+@pytest.fixture
+def mock_api_responses() -> dict[str, dict]:
+    """Mock API response data.
+
+    Returns:
+        Dictionary of mock API responses.
+    """
+    guild_id = 555555555
+    guild_uuid = str(uuid4())
+
+    return {
+        "guild_created": {
+            "id": guild_uuid,
+            "guild_id": guild_id,
+            "guild_name": "Test Guild",
+            "prefix": "!",
+            "created_at": "2024-01-01T12:00:00Z",
+            "updated_at": "2024-01-01T12:00:00Z",
+        },
+        "guild_existing": {
+            "id": guild_uuid,
+            "guild_id": guild_id,
+            "guild_name": "Existing Guild",
+            "prefix": "?",
+            "created_at": "2024-01-01T00:00:00Z",
+            "updated_at": "2024-01-01T00:00:00Z",
+        },
+        "guild_updated": {
+            "id": guild_uuid,
+            "guild_id": guild_id,
+            "guild_name": "Test Guild",
+            "prefix": ">>",
+            "created_at": "2024-01-01T12:00:00Z",
+            "updated_at": "2024-01-01T13:00:00Z",
+        },
+        "health_check": {
+            "status": "healthy",
+            "database": "connected",
+            "timestamp": "2024-01-01T12:00:00Z",
+        },
+        "validation_error": {
+            "detail": [
+                {
+                    "type": "string_too_short",
+                    "loc": ["body", "guild_name"],
+                    "msg": "String should have at least 1 character",
+                }
+            ]
+        },
+        "server_error": {"detail": "Internal server error"},
+    }
+
+
+@pytest.fixture
+def mock_api_client(respx_mock: respx.MockRouter, mock_api_responses: dict[str, dict]) -> respx.MockRouter:
+    """Mock ByteAPIClient HTTP calls using respx.
+
+    Args:
+        respx_mock: respx mock router
+        mock_api_responses: Mock API response data
+
+    Returns:
+        Configured respx mock router.
+    """
+    base_url = "http://localhost:8000"
+
+    # Health check endpoint
+    respx_mock.get(f"{base_url}/health").mock(return_value=Response(200, json=mock_api_responses["health_check"]))
+
+    # Guild endpoints - GET by ID (success)
+    respx_mock.get(f"{base_url}/api/guilds/555555555").mock(
+        return_value=Response(200, json=mock_api_responses["guild_existing"])
+    )
+
+    # Guild endpoints - GET by ID (not found)
+    respx_mock.get(f"{base_url}/api/guilds/999999999").mock(return_value=Response(404, json={"detail": "Not found"}))
+
+    # Guild endpoints - POST (create)
+    respx_mock.post(f"{base_url}/api/guilds").mock(return_value=Response(201, json=mock_api_responses["guild_created"]))
+
+    return respx_mock

tests/unit/bot/__init__.py

@@ -0,0 +1 @@
+"""Bot service unit tests."""