Skip to content

Commit eb9cd45

Browse files
committed
fix: remove transaction commits from cascade delete test
Cascade delete behavior works within transactions after flush(). Remove commit() calls that close transaction prematurely. Fixes test: TestDatabaseIntegrity::test_cascade_delete_all_related_configs
1 parent 4e74d54 commit eb9cd45

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

tests/integration/test_api_endpoints.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -592,12 +592,10 @@ async def test_cascade_delete_all_related_configs(
592592

593593
db_session.add_all([github, forum, so_tag])
594594
await db_session.flush()
595-
await db_session.commit()
596595

597596
# Delete guild
598597
await db_session.delete(guild)
599598
await db_session.flush()
600-
await db_session.commit()
601599

602600
# Verify all configs deleted
603601
github_check = await db_session.execute(select(GitHubConfig).where(GitHubConfig.guild_id == 4444))

0 commit comments

Comments
 (0)