Commit f0cd8f8
fix: scope PYTHONDONTWRITEBYTECODE to test targets only
Addresses review feedback to prevent unintended side effects from
global PYTHONDONTWRITEBYTECODE export.
**Problem:**
With .EXPORT_ALL_VARIABLES enabled, setting PYTHONDONTWRITEBYTECODE=1
globally affected ALL make targets (dev servers, docker builds, docs),
which could:
- Slow down dev servers by preventing .pyc caching
- Affect docker builds that benefit from .pyc files
- Impact other tooling unnecessarily
**Solution:**
- Removed global PYTHONDONTWRITEBYTECODE variable from Makefile
- Set PYTHONDONTWRITEBYTECODE=1 inline for test-related targets only
- Removed from .env.example (no longer needed)
- Kept in CI workflows (appropriate for CI environment)
- Added comment explaining the scoping decision
**Affected targets:**
- test: PYTHONDONTWRITEBYTECODE=1 pytest
- coverage: PYTHONDONTWRITEBYTECODE=1 pytest + coverage
**Unaffected targets (benefit from .pyc caching):**
- run-dev-server, run-dev-bot (faster restarts)
- docker-* (faster container startup)
- docs-* (faster builds)
- install, type-check, lint (faster execution)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 2f93d31 commit f0cd8f8
3 files changed
+10
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | 16 | | |
18 | 17 | | |
19 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
118 | 117 | | |
119 | 118 | | |
120 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
121 | 123 | | |
122 | | - | |
| 124 | + | |
123 | 125 | | |
124 | 126 | | |
125 | | - | |
126 | | - | |
| 127 | + | |
| 128 | + | |
127 | 129 | | |
128 | 130 | | |
129 | 131 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
208 | | - | |
209 | | - | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
210 | 211 | | |
211 | 212 | | |
212 | 213 | | |
| |||
0 commit comments