Make flat_tensor depend on generated schema (pytorch#8803)

swolchok · web-flow · commit 464bd9ecafac · 2025-02-28T08:09:20.000-08:00
When passing -GNinja to cmake to build with Ninja, I was frequently getting errors that executorch/extension/flat_tensor/serialize/flat_tensor_generated.h was not found. This seems to fix them?
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -724,7 +724,6 @@ endif()
 
 if(EXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR)
   add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/extension/flat_tensor)
-  add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/extension/flat_tensor/serialize)
 endif()
 
 if(EXECUTORCH_BUILD_EXTENSION_LLM)
diff --git a/extension/flat_tensor/CMakeLists.txt b/extension/flat_tensor/CMakeLists.txt
@@ -36,6 +36,9 @@ install(
   DESTINATION ${_common_include_directories}
 )
 
+add_subdirectory(serialize)
+add_dependencies(extension_flat_tensor flat_tensor_schema)
+
 if(BUILD_TESTING)
   add_subdirectory(test)
 endif()

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,9 @@ install(`
`36`	`36`	`DESTINATION ${_common_include_directories}`
`37`	`37`	`)`
`38`	`38`
	`39`	`+add_subdirectory(serialize)`
	`40`	`+add_dependencies(extension_flat_tensor flat_tensor_schema)`
	`41`	`+`
`39`	`42`	`if(BUILD_TESTING)`
`40`	`43`	`add_subdirectory(test)`
`41`	`44`	`endif()`