Skip to content

Commit affe7fc

Browse files
lntueJaddyen
authored andcommitted
[libc] Fix dependency list of libc.src.__support.math.exp10f16. (llvm#150434)
1 parent 7b23546 commit affe7fc

File tree

4 files changed

+28
-26
lines changed

4 files changed

+28
-26
lines changed

libc/shared/math/exp10f16.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
#ifndef LLVM_LIBC_SHARED_MATH_EXP10F_H
10-
#define LLVM_LIBC_SHARED_MATH_EXP10F_H
9+
#ifndef LLVM_LIBC_SHARED_MATH_EXP10F16_H
10+
#define LLVM_LIBC_SHARED_MATH_EXP10F16_H
1111

1212
#include "include/llvm-libc-macros/float16-macros.h"
1313
#include "shared/libc_common.h"
@@ -26,4 +26,4 @@ using math::exp10f16;
2626

2727
#endif // LIBC_TYPES_HAS_FLOAT16
2828

29-
#endif // LLVM_LIBC_SHARED_MATH_EXP10F_H
29+
#endif // LLVM_LIBC_SHARED_MATH_EXP10F16_H

libc/src/__support/math/CMakeLists.txt

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -358,11 +358,10 @@ add_header_library(
358358
DEPENDS
359359
.exp10f16_utils
360360
libc.src.__support.FPUtil.fp_bits
361-
src.__support.FPUtil.FEnvImpl
362-
src.__support.FPUtil.FPBits
363-
src.__support.FPUtil.cast
364-
src.__support.FPUtil.rounding_mode
365-
src.__support.FPUtil.except_value_utils
366-
src.__support.macros.optimization
367-
src.__support.macros.properties.cpu_features
361+
libc.src.__support.FPUtil.fenv_impl
362+
libc.src.__support.FPUtil.cast
363+
libc.src.__support.FPUtil.rounding_mode
364+
libc.src.__support.FPUtil.except_value_utils
365+
libc.src.__support.macros.optimization
366+
libc.src.__support.macros.properties.cpu_features
368367
)

libc/src/__support/math/acoshf16.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_ACOSHF_H
10-
#define LLVM_LIBC_SRC___SUPPORT_MATH_ACOSHF_H
9+
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_ACOSHF16_H
10+
#define LLVM_LIBC_SRC___SUPPORT_MATH_ACOSHF16_H
1111

1212
#include "include/llvm-libc-macros/float16-macros.h"
1313

@@ -120,4 +120,4 @@ static constexpr float16 acoshf16(float16 x) {
120120

121121
#endif // LIBC_TYPES_HAS_FLOAT16
122122

123-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_ACOSHF_H
123+
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_ACOSHF16_H

libc/test/shared/shared_math_test.cpp

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,24 +14,24 @@
1414
TEST(LlvmLibcSharedMathTest, AllFloat16) {
1515
int exponent;
1616

17-
EXPECT_FP_EQ(0x0p+0f, LIBC_NAMESPACE::shared::acoshf16(1.0f));
17+
EXPECT_FP_EQ(0x0p+0f16, LIBC_NAMESPACE::shared::acoshf16(1.0f16));
1818

1919
EXPECT_FP_EQ(0x1p+0f16, LIBC_NAMESPACE::shared::exp10f16(0.0f16));
2020

2121
EXPECT_FP_EQ(0x1p+0f16, LIBC_NAMESPACE::shared::expf16(0.0f16));
2222

23-
ASSERT_FP_EQ(float16(8 << 5), LIBC_NAMESPACE::shared::ldexpf16(float(8), 5));
23+
ASSERT_FP_EQ(float16(8 << 5), LIBC_NAMESPACE::shared::ldexpf16(8.0f16, 5));
2424
ASSERT_FP_EQ(float16(-1 * (8 << 5)),
25-
LIBC_NAMESPACE::shared::ldexpf16(float(-8), 5));
25+
LIBC_NAMESPACE::shared::ldexpf16(-8.0f16, 5));
2626

27-
EXPECT_FP_EQ_ALL_ROUNDING(0.75f16,
28-
LIBC_NAMESPACE::shared::frexpf16(24.0f, &exponent));
27+
EXPECT_FP_EQ_ALL_ROUNDING(
28+
0.75f16, LIBC_NAMESPACE::shared::frexpf16(24.0f16, &exponent));
2929
EXPECT_EQ(exponent, 5);
3030

3131
EXPECT_FP_EQ(0x1.921fb6p+0f16, LIBC_NAMESPACE::shared::acosf16(0.0f16));
3232
}
3333

34-
#endif
34+
#endif // LIBC_TYPES_HAS_FLOAT16
3535

3636
TEST(LlvmLibcSharedMathTest, AllFloat) {
3737
int exponent;
@@ -46,9 +46,8 @@ TEST(LlvmLibcSharedMathTest, AllFloat) {
4646
LIBC_NAMESPACE::shared::frexpf(24.0f, &exponent));
4747
EXPECT_EQ(exponent, 5);
4848

49-
ASSERT_FP_EQ(float(8 << 5), LIBC_NAMESPACE::shared::ldexpf(float(8), 5));
50-
ASSERT_FP_EQ(float(-1 * (8 << 5)),
51-
LIBC_NAMESPACE::shared::ldexpf(float(-8), 5));
49+
ASSERT_FP_EQ(float(8 << 5), LIBC_NAMESPACE::shared::ldexpf(8.0f, 5));
50+
ASSERT_FP_EQ(float(-1 * (8 << 5)), LIBC_NAMESPACE::shared::ldexpf(-8.0f, 5));
5251
}
5352

5453
TEST(LlvmLibcSharedMathTest, AllDouble) {
@@ -57,15 +56,19 @@ TEST(LlvmLibcSharedMathTest, AllDouble) {
5756
EXPECT_FP_EQ(0x1p+0, LIBC_NAMESPACE::shared::exp10(0.0));
5857
}
5958

59+
#ifdef LIBC_TYPES_HAS_FLOAT128
60+
6061
TEST(LlvmLibcSharedMathTest, AllFloat128) {
6162
int exponent;
6263

63-
EXPECT_FP_EQ_ALL_ROUNDING(
64-
float128(0.75), LIBC_NAMESPACE::shared::frexpf128(24.0f, &exponent));
64+
EXPECT_FP_EQ_ALL_ROUNDING(float128(0.75), LIBC_NAMESPACE::shared::frexpf128(
65+
float128(24), &exponent));
6566
EXPECT_EQ(exponent, 5);
6667

6768
ASSERT_FP_EQ(float128(8 << 5),
68-
LIBC_NAMESPACE::shared::ldexpf128(float(8), 5));
69+
LIBC_NAMESPACE::shared::ldexpf128(float128(8), 5));
6970
ASSERT_FP_EQ(float128(-1 * (8 << 5)),
70-
LIBC_NAMESPACE::shared::ldexpf128(float(-8), 5));
71+
LIBC_NAMESPACE::shared::ldexpf128(float128(-8), 5));
7172
}
73+
74+
#endif // LIBC_TYPES_HAS_FLOAT128

0 commit comments

Comments
 (0)