Skip to content

Commit cc1832a

Browse files
committed
[mlir][EmitC]Remove the Unused Option in the wrap-emitc-func-in-class Pass (llvm#150577)
This patch removes the option `namedAttribute` which is not used in this pass.
1 parent 3811232 commit cc1832a

File tree

4 files changed

+7
-17
lines changed

4 files changed

+7
-17
lines changed

mlir/include/mlir/Dialect/EmitC/Transforms/Passes.td

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,6 @@ def WrapFuncInClassPass : Pass<"wrap-emitc-func-in-class"> {
5151
```
5252
}];
5353
let dependentDialects = ["emitc::EmitCDialect"];
54-
let options = [Option<
55-
"namedAttribute", "named-attribute", "std::string",
56-
/*default=*/"",
57-
"Attribute key used to extract field names from function argument's "
58-
"dictionary attributes">];
5954
}
6055

6156
#endif // MLIR_DIALECT_EMITC_TRANSFORMS_PASSES

mlir/include/mlir/Dialect/EmitC/Transforms/Transforms.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ ExpressionOp createExpression(Operation *op, OpBuilder &builder);
2929
void populateExpressionPatterns(RewritePatternSet &patterns);
3030

3131
/// Populates 'patterns' with func-related patterns.
32-
void populateFuncPatterns(RewritePatternSet &patterns,
33-
StringRef namedAttribute);
32+
void populateFuncPatterns(RewritePatternSet &patterns);
3433

3534
} // namespace emitc
3635
} // namespace mlir

mlir/lib/Dialect/EmitC/Transforms/WrapFuncInClass.cpp

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ struct WrapFuncInClassPass
3131
Operation *rootOp = getOperation();
3232

3333
RewritePatternSet patterns(&getContext());
34-
populateFuncPatterns(patterns, namedAttribute);
34+
populateFuncPatterns(patterns);
3535

3636
walkAndApplyPatterns(rootOp, std::move(patterns));
3737
}
@@ -43,8 +43,8 @@ struct WrapFuncInClassPass
4343

4444
class WrapFuncInClass : public OpRewritePattern<emitc::FuncOp> {
4545
public:
46-
WrapFuncInClass(MLIRContext *context, StringRef attrName)
47-
: OpRewritePattern<emitc::FuncOp>(context), attributeName(attrName) {}
46+
WrapFuncInClass(MLIRContext *context)
47+
: OpRewritePattern<emitc::FuncOp>(context) {}
4848

4949
LogicalResult matchAndRewrite(emitc::FuncOp funcOp,
5050
PatternRewriter &rewriter) const override {
@@ -101,12 +101,8 @@ class WrapFuncInClass : public OpRewritePattern<emitc::FuncOp> {
101101
rewriter.replaceOp(funcOp, newClassOp);
102102
return success();
103103
}
104-
105-
private:
106-
StringRef attributeName;
107104
};
108105

109-
void mlir::emitc::populateFuncPatterns(RewritePatternSet &patterns,
110-
StringRef namedAttribute) {
111-
patterns.add<WrapFuncInClass>(patterns.getContext(), namedAttribute);
106+
void mlir::emitc::populateFuncPatterns(RewritePatternSet &patterns) {
107+
patterns.add<WrapFuncInClass>(patterns.getContext());
112108
}

mlir/test/Dialect/EmitC/wrap_emitc_func_in_class.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: mlir-opt --wrap-emitc-func-in-class='named-attribute=emitc.name_hint' %s | FileCheck %s
1+
// RUN: mlir-opt --wrap-emitc-func-in-class %s | FileCheck %s
22

33
module attributes { } {
44
emitc.func @model(%arg0: !emitc.array<1xf32> {emitc.name_hint = "another_feature"},

0 commit comments

Comments
 (0)