updated conftest added lint to github actions

Author: Jade Wibbels

.github/workflows/ci.yml

@@ -40,4 +40,8 @@ jobs:
 
       - name: Run tests
         run: |
-          pytest
+          pytest
+
+      - name: Lint code
+        run: |
+          make lint

.gitignore

@@ -25,7 +25,7 @@ share/python-wheels/
 .installed.cfg
 *.egg
 MANIFEST
-package/
+package
 
 # PyInstaller
 #  Usually these files are written by a python script from a template

pyproject.toml

@@ -1,2 +1,8 @@
 [tool.black]
 line-length = 100
+exclude = '''
+/(
+    package 
+    | venv
+)/
+'''

setup.cfg

@@ -1,3 +1,3 @@
 [flake8]
-exclude = venv
-max-line-length = 100
+exclude = venv, package
+max-line-length = 100

tests/conftest.py

@@ -1,9 +1,19 @@
 import pytest
-from app.main import app
+from botocore.stub import Stubber
 from fastapi.testclient import TestClient
 
+from app.main import app
+
 
 @pytest.fixture
 def client():
     with TestClient(app) as client:
         yield client
+
+
+@pytest.fixture
+def mock_dynamodb(request):
+    table = request.param
+    with Stubber(table.meta.client) as stubber:
+        yield stubber
+        stubber.assert_no_pending_responses()

tests/routes/test_posts.py

@@ -1,16 +1,9 @@
 import pytest
-from botocore.stub import Stubber
 
 from app.routes.posts import table
 
 
-@pytest.fixture
-def mock_dynamodb():
-    with Stubber(table.meta.client) as stubber:
-        yield stubber
-        stubber.assert_no_pending_responses()
-
-
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_read_posts(client, mock_dynamodb):
     mock_dynamodb.add_response(
         "scan",
@@ -34,6 +27,7 @@ def test_read_posts(client, mock_dynamodb):
     ]
 
 
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_read_post(client, mock_dynamodb):
     mock_dynamodb.add_response(
         "get_item",
@@ -58,6 +52,7 @@ def test_read_post(client, mock_dynamodb):
     }
 
 
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_create_post(client, mock_dynamodb):
     post_data = {
         "Id": "2",
@@ -74,6 +69,7 @@ def test_create_post(client, mock_dynamodb):
     assert response.json() == {"message": "Post created"}
 
 
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_update_post(client, mock_dynamodb):
     post_data = {
         "Id": "1",
@@ -108,6 +104,7 @@ def test_update_post(client, mock_dynamodb):
     assert response.json() == {"message": "Post with id 1 updated", "updated_attributes": post_data}
 
 
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_delete_post(client, mock_dynamodb):
     mock_dynamodb.add_response(
         "delete_item",

tests/routes/test_users.py

@@ -1,16 +1,9 @@
 import pytest
-from botocore.stub import Stubber
 
 from app.routes.users import table
 
 
-@pytest.fixture
-def mock_dynamodb():
-    with Stubber(table.meta.client) as stubber:
-        yield stubber
-        stubber.assert_no_pending_responses()
-
-
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_read_users(client, mock_dynamodb):
     mock_dynamodb.add_response(
         "scan",
@@ -38,6 +31,7 @@ def test_read_users(client, mock_dynamodb):
     ]
 
 
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_read_user(client, mock_dynamodb):
     mock_dynamodb.add_response(
         "get_item",
@@ -64,6 +58,7 @@ def test_read_user(client, mock_dynamodb):
     }
 
 
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_create_user(client, mock_dynamodb):
     user_data = {
         "Id": "2",
@@ -79,6 +74,7 @@ def test_create_user(client, mock_dynamodb):
     assert response.json() == {"message": "User created"}
 
 
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_update_user(client, mock_dynamodb):
     user_data = {
         "Id": "1",
@@ -107,6 +103,7 @@ def test_update_user(client, mock_dynamodb):
     assert response.json() == {"message": "User with id 1 updated", "updated_attributes": user_data}
 
 
+@pytest.mark.parametrize("mock_dynamodb", [table], indirect=True)
 def test_delete_user(client, mock_dynamodb):
     mock_dynamodb.add_response(
         "delete_item",