Skip to content

Commit 6c4f5b4

Browse files
authored
chore: sync files with Jahia/.github [skip ci] (#47)
1 parent a5fde09 commit 6c4f5b4

File tree

1 file changed

+126
-0
lines changed

1 file changed

+126
-0
lines changed
Lines changed: 126 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,126 @@
1+
---
2+
description: Instructions for reviewing changelog notes as they are being added to Pull Requests. Based upon the style guide available here https://jahia-confluence.atlassian.net/wiki/spaces/PR/pages/2065630/Changelog+Notes+style+guide
3+
applyTo: '.chachalog/**'
4+
---
5+
6+
# Changelog Notes Writing Instructions
7+
8+
Changelog Notes are short, customer-facing descriptions of changes included in a release.
9+
10+
Changelog are written in the .chachalog/ folder at the root of the repository. Changelog are not mandatory and the review should only be performed if a file was modified in this folder.
11+
12+
They are written so that someone familiar with the product (but not with its internal implementation details) can understand:
13+
- what changed or was fixed
14+
- whether they are affected
15+
- what they may need to do (especially for breaking changes)
16+
17+
## Core principles
18+
19+
### Keep it short
20+
- Start with a single-line summary (≤ 120 characters).
21+
- Add 1–2 sentences only if needed for clarity (who is affected, conditions, what to do).
22+
23+
### Be clear
24+
- Use product language and user-visible symptoms.
25+
- Avoid internal jargon and engineering terms.
26+
27+
### Front-load information
28+
- Put the most important information at the start of the sentence.
29+
30+
### Prefer outcomes over implementation
31+
- Focus on the user experiences, not how we built/fixed it.
32+
33+
## Format
34+
- Write changelog entries as plain sentences.
35+
- Do not use structured prefixes such as scope/category labels (for now).
36+
37+
## Recommended sentence patterns
38+
39+
### Start with a strong verb (past tense)
40+
Use past tense verbs and describe the new behavior as a statement of fact:
41+
- Fixed …
42+
- Added …
43+
- Improved …
44+
- Changed …
45+
- Deprecated …
46+
- Removed …
47+
- Secured … / Hardened …
48+
49+
Optional: add a second sentence when needed for conditions, scope, or user action.
50+
51+
Prefer **Fixed** over “Corrected”, and **Improved** over “Made better”.
52+
53+
### Examples
54+
55+
#### ✅ Do
56+
- Fixed locked content so it can no longer be marked as Work in Progress.
57+
- Fixed startup so it no longer generates error logs when no configuration file is present.
58+
59+
#### 🚫 Don’t
60+
- “Fixed startup” (too vague)
61+
- “Fixed method in MissingModulesValidator to return successful validation…” (internal details)
62+
63+
## Breaking changes
64+
65+
A breaking change is something that might require customers to update their configuration, code, or workflow when upgrading.
66+
67+
For breaking changes, always write an entry that is longer and more detailed than usual so customers can:
68+
- quickly check whether the breaking change affects them
69+
- know exactly what actions to take if it does
70+
71+
When documenting a breaking change:
72+
1. Clearly state what was changed and why.
73+
2. Explain who is affected and how they can check if they’re impacted.
74+
3. If the change only affects certain features or setups, say so.
75+
4. Explain, step by step, what customers should do if they are impacted so they can adopt the new version.
76+
77+
## Words and patterns to avoid
78+
79+
### Avoid vague or non-user-facing wording
80+
Avoid terms like:
81+
- “various”, “related”, “some”, “stuff”
82+
83+
Avoid engineering-only descriptions like:
84+
- “refactor”, “cleanup”, “restructured” (unless user behavior changed)
85+
- internal names (classes, methods, services, module names, exceptions)
86+
- “performance improvements” without stating what the user will notice
87+
88+
### Avoid engineering nouns when a user-facing term exists
89+
Avoid:
90+
- “mechanism”, “pipeline”, “framework”, “handler”, “validator”
91+
92+
Avoid “Added a mechanism…”.
93+
Prefer user-facing nouns.
94+
95+
#### ✅ Better alternatives
96+
- Added CSV export for results to simplify reporting.
97+
- Added the ability to export results as CSV to simplify reporting.
98+
99+
#### 🚫 Don’t
100+
- Added a mechanism to export results as CSV to simplify reporting.
101+
102+
## Bug fixes
103+
Describe:
104+
- the user-visible symptom
105+
- (optional) the conditions under which it occurred (when/where/for whom)
106+
107+
Ensure that non-developers can understand what was fixed.
108+
109+
### ✅ Do
110+
- Fixed undo history so it no longer breaks after renaming a file.
111+
- Fixed spurious startup error logs when no configuration file is present.
112+
113+
### 🚫 Don’t
114+
- “Fixed import validation related issues.” (too vague)
115+
- Internal details: “Fixed method in MissingModulesValidator…”
116+
117+
## Enhancements and new features
118+
State the capability and (briefly) the benefit.
119+
120+
### ✅ Do
121+
- Added CSV export for results to simplify reporting.
122+
- Improved search results so they now show the matching field to reduce guesswork.
123+
124+
### 🚫 Don’t
125+
- “Improved performance” (without saying what changed for the user)
126+
- “Implemented feature X” (engineering phrasing)

0 commit comments

Comments
 (0)