fix(snake_case): Sniffs trigger warnings instead of errors

Author: JamesRezo

CHANGELOG.md

@@ -8,6 +8,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.1] - 2021-08-25
+
+### Changed
+
+- Sniffs `SCS1.NamingConventions.SnakeCase*` trigger warnings instead of errors
+
 ## [1.2.0] - 2021-08-24
 
 ### Added

src/SCS1/Sniffs/NamingConventions/SnakeCaseFunctionNameSniff.php

@@ -23,18 +23,18 @@ public function processTokenOutsideScope(File $phpcsFile, $stackPtr)
         // Does this function claim to be magical?
         if (preg_match('|^__[^_]|', $functionName) !== 0) {
             $error = 'Function name "%s" is invalid; only PHP magic methods should be prefixed with a double underscore';
-            $phpcsFile->addError($error, $stackPtr, 'DoubleUnderscore', $errorData);
+            $phpcsFile->addWarning($error, $stackPtr, 'DoubleUnderscore', $errorData);
 
             $functionName = ltrim($functionName, '_');
         }
 
-        if(preg_match(',^(balise|boucle|critere|iterateur)_([a-z0-9_]+),i', $functionName, $matches)) {
+        if (preg_match(',^(balise|boucle|critere|iterateur)_([a-z0-9_]+),i', $functionName, $matches)) {
             $fullName = $functionName;
 
             $functionPrefix = strtolower($matches[1]);
             if ($functionPrefix !== $matches[1]) {
                 $error = 'Special function name "%s" is invalid; Prefix %s must be in lowercase"';
-                $phpcsFile->addError($error, $stackPtr, 'PrefixLowerCase', [$fullName, $functionPrefix]);
+                $phpcsFile->addWarning($error, $stackPtr, 'PrefixLowerCase', [$fullName, $functionPrefix]);
             }
 
             $functionName = $matches[2];
@@ -43,14 +43,14 @@ public function processTokenOutsideScope(File $phpcsFile, $stackPtr)
                 $functionSuffix = strtolower($matches2[1]);
                 if ($functionSuffix !== $matches2[1]) {
                     $error = 'Special function name "%s" is invalid; Suffix %s must be in lowercase"';
-                    $phpcsFile->addError($error, $stackPtr, 'SuffixLowerCase', [$fullName, $functionSuffix]);
+                    $phpcsFile->addWarning($error, $stackPtr, 'SuffixLowerCase', [$fullName, $functionSuffix]);
                 }
             }
 
             if ($functionSuffix) {
                 if ($functionPrefix !== 'balise' && $functionSuffix !== 'dist') {
                     $error = 'Special function name "%s" is invalid; Suffix %s is not allowed with prefix %s"';
-                    $phpcsFile->addError($error, $stackPtr, 'SuffixNotAllowed', [$fullName, $functionSuffix, $functionPrefix]);
+                    $phpcsFile->addWarning($error, $stackPtr, 'SuffixNotAllowed', [$fullName, $functionSuffix, $functionPrefix]);
                 }
                 $functionName = preg_replace(",_$matches2[1]$,", '', $functionName);
             }
@@ -61,10 +61,10 @@ public function processTokenOutsideScope(File $phpcsFile, $stackPtr)
 
             if ($functionName !== strtoupper($functionName)) {
                 $error = 'Special function name "%s" is invalid; Body %s must be in uppercase"';
-                $phpcsFile->addError($error, $stackPtr, 'ScreamingSnakeCase', [$fullName, $functionName]);
+                $phpcsFile->addWarning($error, $stackPtr, 'ScreamingSnakeCase', [$fullName, $functionName]);
             }
         } elseif (!SnakeCase::isSnakeCase($functionName)) {
-            $phpcsFile->addError(
+            $phpcsFile->addWarning(
                 'Function name "%s" is not in snake case format (Suggested name: %s)',
                 $stackPtr,
                 'NotSnakeCase',

src/SCS1/Sniffs/NamingConventions/SnakeCaseVariableNameSniff.php

@@ -20,7 +20,8 @@ protected function processVariable(File $phpcsFile, $stackPtr)
         }
 
         $objOperator = $phpcsFile->findNext([T_WHITESPACE], ($stackPtr + 1), null, true);
-        if ($tokens[$objOperator]['code'] === T_OBJECT_OPERATOR
+        if (
+            $tokens[$objOperator]['code'] === T_OBJECT_OPERATOR
             || $tokens[$objOperator]['code'] === T_NULLSAFE_OBJECT_OPERATOR
         ) {
             // Check to see if we are using a variable from an object.
@@ -42,11 +43,11 @@ protected function processVariable(File $phpcsFile, $stackPtr)
                         $suggestedName = SnakeCase::toSnakeCase($originalVarName);
                         $error = 'Member variable "%s" is not in valid snake_case format (Suggested name: %s)';
                         $data  = [$originalVarName, $suggestedName];
-                        $phpcsFile->addError($error, $var, 'MemberNotSnakeCase', $data);
+                        $phpcsFile->addWarning($error, $var, 'MemberNotSnakeCase', $data);
                     }
-                }//end if
-            }//end if
-        }//end if
+                } //end if
+            } //end if
+        } //end if
 
         $objOperator = $phpcsFile->findPrevious(T_WHITESPACE, ($stackPtr - 1), null, true);
         if ($tokens[$objOperator]['code'] === T_DOUBLE_COLON) {
@@ -61,7 +62,7 @@ protected function processVariable(File $phpcsFile, $stackPtr)
                 $suggestedName = SnakeCase::toSnakeCase($varName);
                 $error = 'Member variable "%s" is not in valid snake_case format (Suggested name: %s)';
                 $data  = [$tokens[$stackPtr]['content'], $suggestedName];
-                $phpcsFile->addError($error, $stackPtr, 'MemberNotSnakeCase', $data);
+                $phpcsFile->addWarning($error, $stackPtr, 'MemberNotSnakeCase', $data);
             }
 
             return;
@@ -82,7 +83,7 @@ protected function processVariable(File $phpcsFile, $stackPtr)
             $suggestedName = SnakeCase::toSnakeCase($originalVarName);
             $error = 'Variable "%s" is not in valid snake case format (Suggested name: %s)';
             $data  = [$originalVarName, $suggestedName];
-            $phpcsFile->addError($error, $stackPtr, 'NotSnakeCase', $data);
+            $phpcsFile->addWarning($error, $stackPtr, 'NotSnakeCase', $data);
         }
     }