Refactoring example #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
commented
Jul 9, 2025
| String.valueOf(vertexAIErrorResponse.code()), | ||
| null | ||
| ); | ||
| if (errorResponse instanceof StreamingErrorResponse streamingErrorResponse) { |
There was a problem hiding this comment.
I didn't go through the exercise to prove this out but I suspect that most of the *UnifiedChatCompletionResponseHandlers will have the exact same code as this implementation. So maybe we could move the contents into the BaseResponseHandler as a new method and have the buildError() override here have one line that simply class back into the base class.
There was a problem hiding this comment.
Responded in original PR:
elastic#128923 (comment)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
Here's an example of what I was thinking to simplify things.
This leverages the
StreamingErrorResponseclass to always providecode(),param(), andtype(). That makes creating the unified error easier.I'll note a few places I think we can still refactor but I wanted to give this as an example.