fix(upgrade): disable auto upgrade in default config

Author: lewis-yeung

src/cli/notice.go

@@ -26,7 +26,6 @@ var noticeCmd = &cobra.Command{
 
 		sh := os.Getenv("POSH_SHELL")
 		cfg, _ := config.Load(configFlag, sh, false)
-		cfg.Upgrade.Cache = env.Cache()
 
 		if notice, hasNotice := cfg.Upgrade.Notice(); hasNotice {
 			fmt.Println(notice)

src/cli/upgrade.go

@@ -58,7 +58,6 @@ var upgradeCmd = &cobra.Command{
 		fmt.Print(terminal.StartProgress())
 
 		cfg, _ := config.Load(configFlag, sh, false)
-		cfg.Upgrade.Cache = env.Cache()
 
 		defer func() {
 			fmt.Print(terminal.StopProgress())

src/cli/upgrade/config.go

@@ -14,7 +14,6 @@ import (
 )
 
 type Config struct {
-	Cache         cache.Cache    `json:"-" toml:"-" yaml:"-"`
 	Source        Source         `json:"source" toml:"source" yaml:"source"`
 	Interval      cache.Duration `json:"interval" toml:"interval" yaml:"interval"`
 	Latest        string         `json:"-" toml:"-" yaml:"-"`

src/cli/upgrade/notice_test.go

@@ -5,9 +5,7 @@ import (
 	"testing"
 
 	"github.com/jandedobbeleer/oh-my-posh/src/build"
-	cache_ "github.com/jandedobbeleer/oh-my-posh/src/cache/mock"
 	"github.com/stretchr/testify/assert"
-	testify_ "github.com/stretchr/testify/mock"
 )
 
 func TestCanUpgrade(t *testing.T) {
@@ -30,10 +28,6 @@ func TestCanUpgrade(t *testing.T) {
 
 	for _, tc := range cases {
 		build.Version = tc.CurrentVersion
-		c := &cache_.Cache{}
-		c.On("Get", CACHEKEY).Return("", tc.Cache)
-		c.On("Set", testify_.Anything, testify_.Anything, testify_.Anything)
-		ugc.Cache = c
 
 		if len(tc.Installer) > 0 {
 			os.Setenv("POSH_INSTALLER", tc.Installer)

src/config/default.go

@@ -197,10 +197,8 @@ func Default(warning bool) *Config {
 			},
 		},
 		Upgrade: &upgrade.Config{
-			Source:        upgrade.CDN,
-			DisplayNotice: true,
-			Auto:          true,
-			Interval:      cache.ONEWEEK,
+			Source:   upgrade.CDN,
+			Interval: cache.ONEWEEK,
 		},
 	}