Add entity and surface valid checks everywhere

Update license copy right year

Author: JanSharp

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2020 Jan Mischak
+Copyright (c) 2020-2022 Jan Mischak
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

changelog.txt

@@ -1,4 +1,9 @@
 ---------------------------------------------------------------------------------------------------
+Version: 1.1.1
+Date: 2022-09-12
+  Bugfixes:
+    - Fix error when pasting to entities with item request proxies while using Copy Paste Modules
+---------------------------------------------------------------------------------------------------
 Version: 1.1.0
 Date: 2020-11-24
   Info:

control.lua

@@ -11,19 +11,23 @@ script.on_event(defines.events.on_player_selected_area, function (event)
   if event.item == "AreaPaste-paste-planner" then
     local player_index = event.player_index
     local player = game.get_player(player_index)
+    ---@cast player -nil
     local copy_source = try_get_copy_source(player)
     if copy_source then
       local copy_source_name = copy_source.name
       local player_position = player.position
       local force = player.force
       local player_insert = player.insert
-      local spill_item_stack = player.surface.spill_item_stack
+      local surface = player.surface
+      local spill_item_stack = surface.spill_item_stack
       local simple_item_stack = {}
       for _, entity in pairs(event.entities) do
-        if entity.name == copy_source_name then
+        if entity.valid and entity.name == copy_source_name then
+          local entity_position = entity.position
+          -- `copy_settings` raises an event, so every LuaObject could be invalidated by this call
           local returned_items = entity.copy_settings(copy_source, player)
-          if next(returned_items) then
-            if player.can_reach_entity(entity) then
+          if next(returned_items) and surface.valid then
+            if entity.valid and player.can_reach_entity(entity) then
               for name, count in pairs(returned_items) do
                 simple_item_stack.name = name
                 simple_item_stack.count = count
@@ -34,7 +38,6 @@ script.on_event(defines.events.on_player_selected_area, function (event)
                 end
               end
             else
-              local entity_position = entity.position
               for name, count in pairs(returned_items) do
                 simple_item_stack.name = name
                 simple_item_stack.count = count
@@ -43,6 +46,9 @@ script.on_event(defines.events.on_player_selected_area, function (event)
             end
           end
         end
+        if not copy_source.valid then
+          break
+        end
       end
     end
   end

info.json

@@ -1,6 +1,6 @@
 {
   "name": "AreaPaste",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "factorio_version": "1.1",
   "title": "Area Paste",
   "author": "JanSharp",