Skip to content

Commit 033f603

Browse files
committed
docs: add code organization improvements from PR omnect#69 review
Document todos for splitting types.rs into domain modules and refactoring macros.rs for better maintainability. Signed-off-by: Jan Zachmann <[email protected]>
1 parent 7e94d56 commit 033f603

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/app/README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,3 +168,10 @@ The Core infrastructure is complete. All Vue components now use the Crux Core ar
168168

169169
- [ ] Remove deprecated capabilities once crux_core provides alternative Effect generation mechanism
170170
- [ ] Refactor `Model.auth_token` to not be serialized to the view model directly. The current approach of removing `#[serde(skip_serializing)]` in `src/app/src/model.rs` is a workaround for `shared_types` deserialization misalignment. A long-term solution should involve either making TypeGen respect `skip_serializing` or separating view-specific model fields.
171+
172+
### Code Organization Improvements (from PR #69 review)
173+
174+
- [ ] Split `types.rs` into domain modules: `src/app/src/types/{auth,device,network,factory_reset,update,common}.rs` ([#69](https://github.com/omnect/omnect-ui/pull/69#discussion_r2563918736))
175+
- [ ] Refactor `macros.rs`: extract builders for simpler re-use in auth/non-auth cases ([#69](https://github.com/omnect/omnect-ui/pull/69#discussion_r2563954064))
176+
- [ ] Refactor `macros.rs`: extract most logic into separate functions and call from macros for better maintainability ([#69](https://github.com/omnect/omnect-ui/pull/69#discussion_r2563954064))
177+
- [ ] Create complex end effects macros (follow-up PR) ([#69](https://github.com/omnect/omnect-ui/pull/69#discussion_r2565173893))

0 commit comments

Comments
 (0)