Merge node v12.16.3

Merges the changes from the node v12.16.3 release into nodejs-mobile.

Author: jaimecbernardo

.eslintrc.js

@@ -85,6 +85,7 @@ module.exports = {
     'comma-style': 'error',
     'computed-property-spacing': 'error',
     'constructor-super': 'error',
+    'default-case-last': 'error',
     'dot-location': ['error', 'property'],
     'dot-notation': 'error',
     'eol-last': 'error',
@@ -244,6 +245,10 @@ module.exports = {
         selector: "CallExpression[callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
         message: 'The first argument should be the `actual`, not the `expected` value.',
       },
+      {
+        selector: "CallExpression[callee.name='isNaN']",
+        message: 'Use Number.isNaN() instead of the global isNaN() function.',
+      },
     ],
     /* eslint-enable max-len */
     'no-return-await': 'error',
@@ -269,6 +274,7 @@ module.exports = {
       functions: false,
       variables: false,
     }],
+    'no-useless-backreference': 'error',
     'no-useless-call': 'error',
     'no-useless-catch': 'error',
     'no-useless-concat': 'error',

.gitignore

@@ -19,7 +19,6 @@
 !.gitkeep
 !.mailmap
 !.nycrc
-!.travis.yml
 !.eslintrc.yaml
 !.cpplint
 
@@ -33,6 +32,7 @@
 /doc/api.xml
 /node
 /node_g
+/gon-config.json
 /*.exe
 /*.swp
 /out
@@ -45,8 +45,8 @@
 /config_fips.gypi
 
 # === Rules for MSVS artifacts ===
-/Debug
-/Release
+Debug/
+Release/
 *.sln
 *.suo
 *.vcxproj*

.mailmap

@@ -23,6 +23,7 @@ Amery <[email protected]> 子丶言 <[email protected]>
 Amit Bendor <[email protected]>
 Anatoli Papirovski <[email protected]> <[email protected]>
 Andreas Offenhaeuser <[email protected]> anoff <[email protected]>
+Andrew Hughes <[email protected]> <[email protected]>
 Andy Bettisworth <[email protected]>
 Angel Stoyanov <[email protected]> atstojanov <[email protected]>
 Anna Henningsen <[email protected]> <[email protected]>
@@ -250,6 +251,7 @@ Masato Ohba <[email protected]>
 Matheus Marchini <[email protected]> <[email protected]>
 Matheus Marchini <[email protected]> <[email protected]>
 Matheus Marchini <[email protected]> <[email protected]>
+Matheus Marchini <[email protected]> <[email protected]>
 Matt Lang <[email protected]> matt-in-a-hat <[email protected]>
 Matt Reed <[email protected]> matthewreed26 <[email protected]>
 Matteo Collina <[email protected]> <[email protected]>
@@ -408,6 +410,7 @@ Travis Meisenheimer <[email protected]> <[email protected]>
 Trevor Burnham <[email protected]> <[email protected]>
 Trivikram Kamat <[email protected]> <[email protected]>
 Tyler Larson <[email protected]>
+Ujjwal Sharma <[email protected]> <[email protected]>
 Viktor Karpov <[email protected]> vitkarpov <[email protected]>
 Vincent Voyer <[email protected]>
 Vladimir de Turckheim <[email protected]>
@@ -423,6 +426,7 @@ Wilson Lin <[email protected]>
 Wyatt Preul <[email protected]> geek <[email protected]>
 Xavier J Ortiz <[email protected]>
 xiaoyu <[email protected]> Poker <[email protected]>
+Yael Hermon <[email protected]> <[email protected]>
 Yazhong Liu <[email protected]> Yazhong Liu <[email protected]>
 Yazhong Liu <[email protected]> Yorkie <[email protected]>
 Yazhong Liu <[email protected]> Yorkie <[email protected]>

.travis.yml

@@ -2636,7 +2636,7 @@ Charles Samborski <[email protected]>
 zhmushan <[email protected]>
 yoshimoto koki <[email protected]>
 Ilarion Halushka <[email protected]>
-Yael Hermon <yaelhe@wix.com>
+Yael Hermon <yaelherm@gmail.com>
 Mitch Hankins <[email protected]>
 Mikko Rantanen <[email protected]>
 wenjun ye <[email protected]>
@@ -2945,5 +2945,81 @@ Chris Oyler <[email protected]>
 Jesper Ek <[email protected]>
 Luciano <[email protected]>
 jens-cappelle <[email protected]>
+bruce-one <[email protected]>
+Jason Macgowan <[email protected]>
+Vincent Dhennin <[email protected]>
+Alex Zherdev <[email protected]>
+Jeny <[email protected]>
+Tchoupinax <[email protected]>
+Sebastien Ahkrin <[email protected]>
+Michael Lehenbauer <[email protected]>
+Harendra Singh <[email protected]>
+Sam Foxman <[email protected]>
+Marek Łabuz <[email protected]>
+Reza Fatahi <[email protected]>
+Priyanka Kore <[email protected]>
+Jan-Philip Gehrcke <[email protected]>
+Maël Nison <[email protected]>
+qualitymanifest <[email protected]>
+Rosen Penev <[email protected]>
+Jeremy Albright <[email protected]>
+Giovanni Campagna <[email protected]>
+Donggeon Lim <[email protected]>
+Tim Costa <[email protected]>
+rene.herrmann <[email protected]>
+Derek Lewis <[email protected]>
+Kirill Ponomarev <[email protected]>
+Soar <[email protected]>
+Tadao Iseki <[email protected]>
+Diego Lafuente <[email protected]>
+Andrew Kuzmenko <[email protected]>
+David Newman <[email protected]>
+Andrey Hohutkin <[email protected]>
+A. Volgin <[email protected]>
+Chris Osborn <[email protected]>
+stephank <[email protected]>
+Taylor Zane Glaeser <[email protected]>
+sutangu <[email protected]>
+Santosh Yadav <[email protected]>
+kresimirfranin <[email protected]>
+Colin Grant <[email protected]>
+Ryan Schmidt <[email protected]>
+Ronald J Kimball <[email protected]>
+Vighnesh Raut <[email protected]>
+SpaceRacet5w2A6l0I <[email protected]>
+Alexander Wang <[email protected]>
+carterbancroft <[email protected]>
+Egor Pavlov <[email protected]>
+Parker Bjur <[email protected]>
+Yakov Litvin <[email protected]>
+Eran Levin <[email protected]>
+Alexander Smarus <[email protected]>
+kenzo-spaulding <[email protected]>
+Rusty Conover <[email protected]>
+aaccttrr <[email protected]>
+ConorDavenport <[email protected]>
+Dylan Coakley <[email protected]>
+Steffen <[email protected]>
+Conor ONeill <[email protected]>
+tsabolov <[email protected]>
+Swagat Konchada <[email protected]>
+Yuhanun Citgez <[email protected]>
+Danielle Adams <[email protected]>
+Andrey Pechkurov <[email protected]>
+Jeff <[email protected]>
+simon <[email protected]>
+Eric Eastwood <[email protected]>
+unknown <[email protected]>
+zfx <[email protected]>
+Vita Batrla <[email protected]>
+André Draszik <[email protected]>
+ProdipRoy89 <[email protected]>
+Andrew Neitsch <[email protected]>
+RamanandPatil <[email protected]>
+forfun414 <[email protected]>
+David Gilbertson <[email protected]>
+Sergey Zelenov <[email protected]>
+Eric Bickle <[email protected]>
+Joe Pea <[email protected]>
 
 # Generated by tools/update-authors.js

AUTHORS

@@ -28,11 +28,13 @@ file a new issue.
     * [Running Coverage](#running-coverage)
     * [Building the documentation](#building-the-documentation)
     * [Building a debug build](#building-a-debug-build)
+    * [Building an ASAN build](#building-an-asan-build)
+    * [Troubleshooting Unix and macOS builds](#troubleshooting-unix-and-macos-builds)
   * [Windows](#windows)
     * [Prerequisites](#prerequisites)
       * [Option 1: Manual install](#option-1-manual-install)
       * [Option 2: Automated install with Boxstarter](#option-2-automated-install-with-boxstarter)
-    * [Building Node.js](#building-nodejs-1)
+    * [Building Node.js](#building-nodejs-2)
   * [Android/Android-based devices (e.g. Firefox OS)](#androidandroid-based-devices-eg-firefox-os)
 * [`Intl` (ECMA-402) support](#intl-ecma-402-support)
   * [Default: `small-icu` (English only) support](#default-small-icu-english-only-support)
@@ -42,7 +44,7 @@ file a new issue.
   * [Building without Intl support](#building-without-intl-support)
     * [Unix/macOS](#unixmacos-1)
     * [Windows](#windows-2)
-  * [Use existing installed ICU (Unix/macOS only)](#use-existing-installed-icu-unixmacOS-only)
+  * [Use existing installed ICU (Unix/macOS only)](#use-existing-installed-icu-unixmacos-only)
   * [Build with a specific ICU](#build-with-a-specific-icu)
     * [Unix/macOS](#unixmacos-2)
     * [Windows](#windows-3)
@@ -164,7 +166,7 @@ Binaries at <https://nodejs.org/download/release/> are produced on:
 | Binary package        | Platform and Toolchain                                                   |
 | --------------------- | ------------------------------------------------------------------------ |
 | aix-ppc64             | AIX 7.1 TL05 on PPC64BE with GCC 6                                       |
-| darwin-x64 (and .pkg) | macOS 10.11, Xcode Command Line Tools 8 with -mmacosx-version-min=10.10  |
+| darwin-x64 (and .pkg) | macOS 10.15, Xcode Command Line Tools 11 with -mmacosx-version-min=10.10 |
 | linux-arm64           | CentOS 7 with devtoolset-6 / GCC 6                                       |
 | linux-armv7l          | Cross-compiled on Ubuntu 16.04 x64 with [custom GCC toolchain](https://github.com/rvagg/rpi-newer-crosstools)   |
 | linux-ppc64le         | CentOS 7 with devtoolset-6 / GCC 6 <sup>[7](#fn7)</sup>                  |
@@ -249,6 +251,7 @@ Installation via Linux package manager can be achieved with:
 * Fedora: `sudo dnf install python gcc-c++ make`
 * CentOS and RHEL: `sudo yum install python gcc-c++ make`
 * OpenSUSE: `sudo zypper install python gcc-c++ make`
+* Arch Linux, Manjaro: `sudo pacman -S python gcc make`
 
 FreeBSD and OpenBSD users may also need to install `libexecinfo`.
 
@@ -494,6 +497,33 @@ $ gdb /opt/node-debug/node core.node.8.1535359906
 $ backtrace
 ```
 
+#### Building an ASAN build
+
+[ASAN](https://github.com/google/sanitizers) can help detect various memory
+related bugs. ASAN builds are currently only supported on linux.
+If you want to check it on Windows or macOS or you want a consistent toolchain
+on Linux, you can try [Docker](https://www.docker.com/products/docker-desktop)
+ (using an image like `gengjiawen/node-build:2020-02-14`).
+
+The `--debug` is not necessary and will slow down build and testing, but it can
+show clear stacktrace if ASAN hits an issue.
+
+``` console
+$  ./configure --debug --enable-asan && make -j4
+$ make test-only
+```
+
+#### Troubleshooting Unix and macOS builds
+
+Stale builds can sometimes result in `file not found` errors while building.
+This and some other problems can be resolved with `make distclean`. The
+`distclean` recipe aggressively removes build artifacts. You will need to
+build again (`make -j4`). Since all build artifacts have been removed, this
+rebuild may take a lot more time than previous builds. Additionally,
+`distclean` removes the file that stores the results of `./configure`. If you
+ran `./configure` with non-default options (such as `--debug`), you will need
+to run it again before invoking `make -j4`.
+
 ### Windows
 
 #### Prerequisites
@@ -531,7 +561,6 @@ Optional requirements for compiling for Windows 10 on ARM (ARM64):
 * Windows 10 SDK 10.0.17763.0 or newer
 
 ##### Option 2: Automated install with Boxstarter
-<a name="boxstarter"></a>
 
 A [Boxstarter](https://boxstarter.org/) script can be used for easy setup of
 Windows systems with all the required prerequisites for Node.js development.
@@ -542,7 +571,7 @@ packages:
   Unix tools added to the `PATH`.
 * [Python 3.x](https://chocolatey.org/packages/python) and
   [legacy Python](https://chocolatey.org/packages/python2)
-* [Visual Studio 2017 Build Tools](https://chocolatey.org/packages/visualstudio2017buildtools)
+* [Visual Studio 2019 Build Tools](https://chocolatey.org/packages/visualstudio2019buildtools)
   with [Visual C++ workload](https://chocolatey.org/packages/visualstudio2017-workload-vctools)
 * [NetWide Assembler](https://chocolatey.org/packages/nasm)