fix: use os.path.realpath() to accommodate "private/" symlinks on macos #288
+46
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, /var is a symlink to /private/var. This resulted in test_path_file_move failing because the code would: - resolve paths with realpath() → /private/var/... - calculate relative path with os.path.relpath() → creates paths like ../../../../../../private/var/... - on subsequent calls, joining this relative path with the unresolved root caused /private/private/var/...
- tests macOS behavior, eg., /var => /private/var
allison-truhlar
changed the title
allison-truhlar
changed the title
neomorphic
approved these changes
Jan 15, 2026
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
I had done this already for another piece of code in commit 5d69b8f, so I approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was triggered by test_patch_file_move in test_endpoints.py failing only when running on macOS due to /var being a symlink to /private/var. To fix this, and also to fix the new symlink redirect code on macOS, instances of os.path.normpath and os.path.abspath were replaced with os.realpath.
You can test this by running test_endpoints.py on macOS without the change (should fail) and then with the change (should pass).
You can also test it by running
pixi run test-uion macOS without the change (13/16 tests will fail) and then with the change (all should pass).@krokicki @neomorphic