Merge pull request #57 from JansthcirlU/56-add-tests-for-exhaustive-enum-checking

Fixed enum exhaustiveness, treat warnings as errors

Author: JansthcirlU

src/Mermaid.Flowcharts/Mermaid.Flowcharts.csproj

@@ -4,6 +4,7 @@
     <TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <PropertyGroup>

src/Mermaid.Flowcharts/Styling/Attributes/DashOffset.cs

@@ -61,6 +61,7 @@ private string ToSubtypeMermaidString()
         {
             LengthDashOffset ldo => ldo.LengthOffset.ToCss(),
             PercentageDashOffset pdo => pdo.PercentageOffset.ToNumericalString(),
-            NumericalDashOffset ndo => ndo.Size.ToNumberString()
+            NumericalDashOffset ndo => ndo.Size.ToNumberString(),
+            _ => throw new NotImplementedException($"Cannot convert unsupported {nameof(DashOffset)} subtype to Mermaid string: {GetType().Name}.")
         };
 }

src/Mermaid.Flowcharts/Styling/Attributes/DashSize.cs

@@ -61,6 +61,7 @@ public string ToMermaidString()
         {
             LengthDashSize lds => lds.LengthSize.ToCss(),
             PercentageDashSize pds => pds.PercentageSize.ToNumericalString(),
-            NumericalDashSize nds => nds.Size.ToNumberString()
+            NumericalDashSize nds => nds.Size.ToNumberString(),
+            _ => throw new NotImplementedException($"Cannot convert unsupported {nameof(DashSize)} subtype to Mermaid string: {GetType().Name}.")
         };
 }

src/Mermaid.Flowcharts/Styling/Attributes/Fonts/FontSize.cs

@@ -39,6 +39,7 @@ private string ToSubtypeMermaidString()
             AbsoluteFontSize afs => afs.Size.ToAbsoluteSizeString(),
             RelativeFontSize rfs => rfs.Size.ToRelativeSizeString(),
             PercentageFontSize pfs => pfs.SizePercentage.ToNumericalString(),
-            LengthFontSize lfs => lfs.SizeLength.ToCss()
+            LengthFontSize lfs => lfs.SizeLength.ToCss(),
+            _ => throw new NotImplementedException($"Cannot convert unsupported {nameof(FontSize)} subtype to Mermaid string: {GetType().Name}.")
         };
 }

src/Mermaid.Flowcharts/Styling/Attributes/Fonts/FontWeight.cs

@@ -43,6 +43,7 @@ private string ToSubtypeMermaidString()
         => this switch
         {
             RelativeFontWeight rfw => rfw.Weight.ToFontWeightTypeString(),
-            NumericalFontWeight nfw => nfw.Weight.ToNumberString()
+            NumericalFontWeight nfw => nfw.Weight.ToNumberString(),
+            _ => throw new NotImplementedException($"Cannot convert unsupported {nameof(FontWeight)} subtype to Mermaid string: {GetType().Name}.")
         };
 }

src/Mermaid.Flowcharts/Styling/Attributes/StrokeWidth.cs

@@ -51,6 +51,7 @@ private string ToSubtypeMermaidString()
         {
             LengthStrokeWidth lsw => lsw.Width.ToCss(),
             PercentageStrokeWidth psw => psw.PercentageWidth.ToNumericalString(),
-            NumericalStrokeWidth nsw => nsw.Width.ToNumberString()
+            NumericalStrokeWidth nsw => nsw.Width.ToNumberString(),
+            _ => throw new NotImplementedException($"Cannot convert unsupported {nameof(StrokeWidth)} subtype to Mermaid string: {GetType().Name}.")
         };
 }

src/Mermaid.Flowcharts/Styling/EnumExtensions.cs

@@ -15,13 +15,21 @@ public static string ToAbsoluteSizeString(this AbsoluteSize absoluteSize)
             AbsoluteSize.XLarge => "x-large",
             AbsoluteSize.XxLarge => "xx-large",
             AbsoluteSize.XxxLarge => "xxx-large",
+            _ => throw new ArgumentOutOfRangeException(
+                    nameof(absoluteSize),
+                    absoluteSize,
+                    $"Unsupported {nameof(AbsoluteSize)} value: {absoluteSize}.")
         };
 
     public static string ToRelativeSizeString(this RelativeSize relativeSize)
         => relativeSize switch
         {
             RelativeSize.Larger => "larger",
             RelativeSize.Smaller => "smaller",
+            _ => throw new ArgumentOutOfRangeException(
+                    nameof(relativeSize),
+                    relativeSize,
+                    $"Unsupported {nameof(RelativeSize)} value: {relativeSize}.")
         };
 
     public static string ToFontWeightTypeString(this FontWeightType fontWeight)
@@ -31,6 +39,10 @@ public static string ToFontWeightTypeString(this FontWeightType fontWeight)
             FontWeightType.Bold => "bold",
             FontWeightType.Bolder => "bolder",
             FontWeightType.Lighter => "lighter",
+            _ => throw new ArgumentOutOfRangeException(
+                    nameof(fontWeight),
+                    fontWeight,
+                    $"Unsupported {nameof(FontWeightType)} value: {fontWeight}.")
         };
 
     public static string ToStrokeLineCapTypeString(this StrokeLineCapType strokeLineCapType)
@@ -39,6 +51,10 @@ public static string ToStrokeLineCapTypeString(this StrokeLineCapType strokeLine
             StrokeLineCapType.Butt => "butt",
             StrokeLineCapType.Round => "round",
             StrokeLineCapType.Square => "square",
+            _ => throw new ArgumentOutOfRangeException(
+                    nameof(strokeLineCapType),
+                    strokeLineCapType,
+                    $"Unsupported {nameof(StrokeLineCapType)} value: {strokeLineCapType}.")
         };
 
     public static string ToStrokeLineJoinTypeString(this StrokeLineJoinType strokeLineJoinType)
@@ -49,6 +65,10 @@ public static string ToStrokeLineJoinTypeString(this StrokeLineJoinType strokeLi
             StrokeLineJoinType.Bevel => "bevel",
             StrokeLineJoinType.MiterClip => "miter-clip",
             StrokeLineJoinType.Round => "round",
+            _ => throw new ArgumentOutOfRangeException(
+                    nameof(strokeLineJoinType),
+                    strokeLineJoinType,
+                    $"Unsupported {nameof(StrokeLineJoinType)} value: {strokeLineJoinType}.")
         };
 
     public static string ToUnitString(this Unit unit)
@@ -68,5 +88,9 @@ public static string ToUnitString(this Unit unit)
             Unit.Mm => "mm",
             Unit.Cm => "cm",
             Unit.In => "in",
+            _ => throw new ArgumentOutOfRangeException(
+                    nameof(unit),
+                    unit,
+                    $"Unsupported {nameof(Unit)} value: {unit}.")
         };
 }

tests/Mermaid.Flowcharts.Tests/Mermaid.Flowcharts.Tests.csproj

@@ -6,6 +6,7 @@
     <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
     <IsTestProject>true</IsTestProject>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>