Merge pull request #64 from JansthcirlU/63-add-non-generic-subgraphcreate-factory-method-to-be-backwards-compatible

63 add non generic subgraphcreate factory method to be backwards compatible

Author: JansthcirlU

src/Mermaid.Flowcharts/Subgraphs/Subgraph.cs

@@ -42,6 +42,12 @@ public static Subgraph Create<TNodeText>(string identifier, TNodeText title, Sub
         where TNodeText : INodeText
         => new(NodeIdentifier.FromString(identifier), title, direction);
 
+    public static Subgraph CreateNew(string title, SubgraphDirection? direction = null)
+        => CreateNew<MermaidUnicodeText>(title, direction);
+
+    public static Subgraph Create(string identifier, string title, SubgraphDirection? direction = null)
+        => Create<MermaidUnicodeText>(identifier, title, direction);
+
     public Subgraph AddNode(INode node)
     {
         if (node is Node nd && Nodes.Any(nd.Equals))

tests/Mermaid.Flowcharts.Tests/NodeTests.cs

@@ -135,12 +135,13 @@ public void CreateNew_WhenNonGeneric_ShouldHaveGuidIdentifier()
     public void Create_WhenNonGeneric_ShouldBeUnicode()
     {
         // Arrange
-        Node node = Node.Create("A", "a");
+        Node node = Node.Create("a", "A");
 
         // Act
         INodeText text = node.Text;
 
         // Assert
         Assert.True(text is MermaidUnicodeText);
+        Assert.Equal("A", text.Value);
     }
 }

tests/Mermaid.Flowcharts.Tests/SubgraphTests.cs

@@ -309,4 +309,32 @@ public void ToMermaidString_WhenIndentations(string identifier, string title, st
         // Assert
         Assert.Equal(expected, actual);
     }
+
+    [Fact]
+    public void CreateNew_WhenNonGeneric_ShouldHaveGuidIdentifier()
+    {
+        // Arrange
+        Subgraph subgraph = Subgraph.CreateNew("text");
+
+        // Act
+        bool parsed = Guid.TryParseExact(subgraph.Id.Value, "D", out Guid guid);
+
+        // Assert
+        Assert.True(parsed);
+        Assert.True(guid != Guid.Empty);
+    }
+
+    [Fact]
+    public void Create_WhenNonGeneric_ShouldBeUnicode()
+    {
+        // Arrange
+        Subgraph subgraph = Subgraph.Create("sg", "SG");
+
+        // Act
+        INodeText title = subgraph.Title;
+
+        // Assert
+        Assert.True(title is MermaidUnicodeText);
+        Assert.Equal("SG", title.Value);
+    }
 }