Skip to content

Commit 38d8a7c

Browse files
authored
Refactor
Improves the readability of the test. Replaces manual exception handling with the testing framework's built-in features (e.g., assertThrows), improving readability, maintainability, and debugging efficiency.
1 parent 46a971a commit 38d8a7c

File tree

1 file changed

+7
-11
lines changed
  • janusgraph-backend-testutils/src/main/java/org/janusgraph/diskstorage/log

1 file changed

+7
-11
lines changed

janusgraph-backend-testutils/src/main/java/org/janusgraph/diskstorage/log/LogTest.java

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -226,18 +226,14 @@ public void testFuzzMessagesSerial() throws Exception {
226226
}
227227

228228
@Test
229-
public void testReadMarkerCompatibility() throws Exception {
229+
public void testReadMarkerCompatibility() {
230230
Log l1 = manager.openLog("testx");
231-
l1.registerReader(ReadMarker.fromIdentifierOrNow("mark"),new StoringReader(0));
232-
l1.registerReader(ReadMarker.fromIdentifierOrTime("mark", Instant.now().minusMillis(100)),new StoringReader(1));
233-
try {
234-
l1.registerReader(ReadMarker.fromIdentifierOrNow("other"));
235-
fail();
236-
} catch (IllegalArgumentException ignored) {}
237-
try {
238-
l1.registerReader(ReadMarker.fromTime(Instant.now().minusMillis(100)));
239-
fail();
240-
} catch (IllegalArgumentException ignored) {}
231+
l1.registerReader(ReadMarker.fromIdentifierOrNow("mark"), new StoringReader(0));
232+
l1.registerReader(ReadMarker.fromIdentifierOrTime("mark", Instant.now().minusMillis(100)), new StoringReader(1));
233+
234+
assertThrows(IllegalArgumentException.class, () -> l1.registerReader(ReadMarker.fromIdentifierOrNow("other")));
235+
assertThrows(IllegalArgumentException.class, () -> l1.registerReader(ReadMarker.fromTime(Instant.now().minusMillis(100))));
236+
241237
l1.registerReader(ReadMarker.fromNow(), new StoringReader(2));
242238
}
243239

0 commit comments

Comments
 (0)