Skip to content

Commit 5ee7151

Browse files
Rian-Ismaelporunov
authored andcommitted
Update OrJanusPredicateTest.java
Improves the readability of the test. The assertions are clearer and include descriptive messages, making it easier to identify which assertion fails. This enhances code maintainability, understanding and debugging efficiency. Signed-off-by: Rian-Ismael <[email protected]>
1 parent a71898b commit 5ee7151

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

janusgraph-test/src/test/java/org/janusgraph/graphdb/predicate/OrJanusPredicateTest.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,10 @@ ConnectiveJanusPredicate getNegatePredicate(List<JanusGraphPredicate> childPredi
4747

4848
@Test
4949
public void testIsQNF() {
50-
assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)).isQNF());
51-
assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new OrJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF());
52-
assertFalse(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new AndJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF());
50+
assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)).isQNF(), "Single PREFIX EQUAL should be QNF");
51+
assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new OrJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF(),
52+
"PREFIX EQUAL with OR(JANUS(PREFIX EQUAL)) should be QNF");
53+
assertFalse(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new AndJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF(),
54+
"PREFIX EQUAL with AND(JANUS(PREFIX EQUAL)) should not be QNF");
5355
}
5456
}

0 commit comments

Comments
 (0)