Skip to content

Commit 33a95e9

Browse files
committed
Do not raise exception when checking PlatformIO Core for updates and Internet is off-line
1 parent c289632 commit 33a95e9

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

pioinstaller/core.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def _install_platformio_core(shutdown_piohome=True, develop=False, ignore_python
141141

142142

143143
def check(dev=False, auto_upgrade=False, version_spec=None):
144-
# pylint: disable=bad-option-value, import-outside-toplevel, unused-import, import-error, unused-variable, cyclic-import
144+
# pylint: disable=bad-option-value, import-outside-toplevel, unused-import, import-error, unused-variable, cyclic-import, too-many-branches
145145
from pioinstaller import penv
146146

147147
platformio_exe = os.path.join(
@@ -238,7 +238,11 @@ def check(dev=False, auto_upgrade=False, version_spec=None):
238238
if not last_piocore_version_check:
239239
return result
240240

241-
upgrade_core(platformio_exe, dev)
241+
# capture exception when Internet is off-line
242+
try:
243+
upgrade_core(platformio_exe, dev)
244+
except: # pylint:disable=bare-except
245+
return result
242246

243247
try:
244248
result.update(fetch_python_state(python_exe))

0 commit comments

Comments
 (0)