#49 re-virtualized SecureRandom methods

Author: JasonBock

Directory.Build.props

@@ -9,6 +9,6 @@
 		<Nullable>enable</Nullable>
 		<TargetFramework>net9.0</TargetFramework>
 		<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
-		<Version>13.0.0</Version>
+		<Version>13.0.1</Version>
 	</PropertyGroup>
 </Project>

Spackle/SecureRandom.cs

@@ -1,11 +1,11 @@
-using Spackle.Extensions;
-using System.Globalization;
+using System.Globalization;
 using System.Numerics;
 using System.Security.Cryptography;
 using System.Text;
 
 namespace Spackle;
 
+#pragma warning disable CA1716 // Identifiers should not match keywords
 /// <summary>
 /// Provides random APIs backed by the security of <see cref="RandomNumberGenerator"/>.
 /// </summary>
@@ -336,7 +336,7 @@ public int[] GetInt32Values(uint numberOfElements, Range range, ValueGeneration
    /// Returns a new random <see cref="int"/> value between 0 (inclusive) 
    /// and <c>Int32.MaxValue</c> (exclusive).
    /// </returns>
-   public int Next() => 
+   public virtual int Next() => 
 		this.Next(int.MaxValue);
 
    /// <summary>
@@ -348,7 +348,7 @@ public int Next() =>
    /// and <paramref name="maxValue"/> (exclusive).
    /// </returns>
    /// <exception cref="ArgumentException">Thrown if <paramref name="maxValue"/> is less than zero.</exception>
-   public int Next(int maxValue)
+   public virtual int Next(int maxValue)
 	{
 		if (maxValue < 0)
 		{
@@ -372,7 +372,7 @@ public int Next(int maxValue)
 	/// <exception cref="ArgumentException">
 	/// Thrown if <paramref name="maxValue"/> is less than <paramref name="minValue"/>.
 	/// </exception>
-	public int Next(int minValue, int maxValue)
+	public virtual int Next(int minValue, int maxValue)
 	{
 		if (maxValue < minValue)
 		{
@@ -409,18 +409,19 @@ public bool NextBoolean() =>
    /// Fills the given buffer with random bits.
    /// </summary>
    /// <param name="buffer">The buffer to populate.</param>
-   public void NextBytes(byte[] buffer) => 
+   public virtual void NextBytes(byte[] buffer) => 
 		this.Generator.GetBytes(buffer);
 
    /// <summary>
    /// Gets a random <see cref="double"/> number.
    /// </summary>
    /// <returns>A <see cref="double"/> number.</returns>
-   public double NextDouble() => 
+   public virtual double NextDouble() => 
 		this.Next(int.MaxValue) * MaxInt32Inverse;
 
    /// <summary>
    /// Gets the underlying <see cref="RandomNumberGenerator"/>.
    /// </summary>
    public RandomNumberGenerator Generator { get; }
-}
+}
+#pragma warning restore CA1716 // Identifiers should not match keywords

changelog.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [13.0.1] - 2024.11.28
+
+### Changed
+- Made methods on `SecureRandom` virtual that used to be `override`s (issue [#49](https://github.com/JasonBock/SpackleNet/issues/49))
+
 ## [13.0.0] - 2024.11.27
 
 ### Changed