Issue-2 Removed dead code

Author: Jason Valdez

src/IntegrationPostgreSqlTests/BulkLoading/SqlBulkCopyUtilitySpy.cs

@@ -10,7 +10,6 @@ public class SqlBulkCopyUtilitySpy: BulkLoader.ISqlBulkCopyUtility
 
         public void BulkCopy<T>(string tableName,
             NpgsqlConnection conn, 
-            BulkLoader.SqlBulkCopyOptions options,
             BulkLoader.TargetProperty[] targetProperties,
             IEnumerable<T> toInsert)
         {
@@ -19,7 +18,6 @@ public void BulkCopy<T>(string tableName,
             new BulkLoader.SqlBulkCopyUtility()
                 .BulkCopy(tableName,
                     conn, 
-                    options,
                     targetProperties,
                     toInsert);
         }

src/IntegrationShared/IntegrationCompatibilityTests.csproj

@@ -8,8 +8,8 @@
     <ProjectGuid>{C15AA0BA-7C38-4CCA-9BC1-2F530C051445}</ProjectGuid>
     <OutputType>Library</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
-    <RootNamespace>IntegrationShared</RootNamespace>
-    <AssemblyName>IntegrationShared</AssemblyName>
+    <RootNamespace>ivaldez.Sql.IntegrationShared</RootNamespace>
+    <AssemblyName>ivaldez.Sql.IntegrationShared</AssemblyName>
     <TargetFrameworkVersion>v4.7</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <Deterministic>true</Deterministic>

src/SharedTestFramework/SharedTestFramework.csproj

@@ -7,8 +7,8 @@
     <ProjectGuid>{692D1C7C-4403-468B-B2E8-51DA8EF0C654}</ProjectGuid>
     <OutputType>Library</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
-    <RootNamespace>SharedTestFramework</RootNamespace>
-    <AssemblyName>SharedTestFramework</AssemblyName>
+    <RootNamespace>ivaldez.Sql.SharedTestFramework</RootNamespace>
+    <AssemblyName>ivaldez.Sql.SharedTestFramework</AssemblyName>
     <TargetFrameworkVersion>v4.7</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <Deterministic>true</Deterministic>

src/ivaldez.SqlBulkLoader.PostgreSql/BulkLoader.cs

@@ -112,23 +112,14 @@ public void Insert<T>(string tableName,
             bool noBatch = false)
         {
             var targetProperties = GetTargetProperties<T>(propertiesToIgnore, renameFields);
-
-            //var options = SqlBulkCopyOptions.CheckConstraints | SqlBulkCopyOptions.TableLock;
-
-            //if (keepIdentityColumnValue)
-            //{
-            //    options |= SqlBulkCopyOptions.KeepIdentity;
-            //}
-
-            SqlBulkCopyOptions options = null;
-
+            
             if (noBatch)
             {
-                BulkCopyWithNoBatching(tableName, conn, dataToInsert, options, targetProperties);
+                BulkCopyWithNoBatching(tableName, conn, dataToInsert, targetProperties);
             }
             else
             {
-                BulkCopyWithBatching(tableName, conn, dataToInsert, batchSize, options, targetProperties);
+                BulkCopyWithBatching(tableName, conn, dataToInsert, batchSize, targetProperties);
             }
         }
 
@@ -138,7 +129,7 @@ public void Insert<T>(string tableName,
         /// </summary>
         public class SqlBulkCopyUtility: ISqlBulkCopyUtility
         {
-            public void BulkCopy<T>(string tableName, NpgsqlConnection conn, SqlBulkCopyOptions options,
+            public void BulkCopy<T>(string tableName, NpgsqlConnection conn,
                 TargetProperty[] targetProperties, IEnumerable<T> toInsert)
             {
                 var propertyList = new List<string>();
@@ -173,7 +164,7 @@ public void BulkCopy<T>(string tableName, NpgsqlConnection conn, SqlBulkCopyOpti
         /// </summary>
         public interface ISqlBulkCopyUtility
         {
-            void BulkCopy<T>(string tableName, NpgsqlConnection conn, SqlBulkCopyOptions options,
+            void BulkCopy<T>(string tableName, NpgsqlConnection conn,
                 TargetProperty[] targetProperties, IEnumerable<T> toInsert);
         }
 
@@ -185,19 +176,14 @@ public class TargetProperty
             public string OriginalName { get; set; }
         }
 
-        public class SqlBulkCopyOptions
-        {
-
-        }
-
         private void BulkCopyWithNoBatching<T>(string tableName, NpgsqlConnection conn, IEnumerable<T> dataToInsert,
-            SqlBulkCopyOptions options, TargetProperty[] targetProperties)
+            TargetProperty[] targetProperties)
         {
-            _sqlBulkCopyUtility.BulkCopy(tableName, conn, options, targetProperties, dataToInsert);
+            _sqlBulkCopyUtility.BulkCopy(tableName, conn, targetProperties, dataToInsert);
         }
 
         private void BulkCopyWithBatching<T>(string tableName, NpgsqlConnection conn, IEnumerable<T> dataToInsert, int batchSize,
-            SqlBulkCopyOptions options, TargetProperty[] targetProperties)
+            TargetProperty[] targetProperties)
         {
             var batch = new List<T>(batchSize);
 
@@ -207,14 +193,14 @@ private void BulkCopyWithBatching<T>(string tableName, NpgsqlConnection conn, IE
 
                 if (batch.Count >= batchSize)
                 {
-                    _sqlBulkCopyUtility.BulkCopy(tableName, conn, options, targetProperties, batch);
+                    _sqlBulkCopyUtility.BulkCopy(tableName, conn, targetProperties, batch);
                     batch.Clear();
                 }
             }
 
             if (batch.Any())
             {
-                _sqlBulkCopyUtility.BulkCopy(tableName, conn, options, targetProperties, batch);
+                _sqlBulkCopyUtility.BulkCopy(tableName, conn, targetProperties, batch);
                 batch.Clear();
             }
         }