Check value of update_existing for true/false.

Author: dblock

src/action.ts

@@ -9,7 +9,16 @@ import { FrontMatterAttributes, listToArray, setOutputs } from './helpers'
 export async function createAnIssue (tools: Toolkit) {
   const template = tools.inputs.filename || '.github/ISSUE_TEMPLATE.md'
   const assignees = tools.inputs.assignees
-  const updateExisting: Boolean | null = tools.inputs.update_existing ? tools.inputs.update_existing === 'true' : null
+  let updateExisting: Boolean | null = null
+  if (tools.inputs.update_existing) {
+    if (tools.inputs.update_existing === 'true') {
+      updateExisting = true
+    } else if (tools.inputs.update_existing === 'false') {
+      updateExisting = false
+    } else {
+      tools.exit.failure(`Invalid value update_existing=${tools.inputs.update_existing}, must be one of true or false`)
+    }
+  }
   const env = nunjucks.configure({ autoescape: false })
   env.addFilter('date', dateFilter)
 
@@ -46,7 +55,7 @@ export async function createAnIssue (tools: Toolkit) {
       tools.exit.failure(err)
     }
     if (existingIssue) {
-      if (! updateExisting) {
+      if (updateExisting === false) {
         tools.exit.success(`Existing issue ${existingIssue.title}#${existingIssue.number}: ${existingIssue.html_url} found but not updated`)
       } else {
         try {

tests/__snapshots__/index.test.ts.snap

@@ -1,5 +1,18 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`create-an-issue checks the value of update_existing 1`] = `
+Object {
+  "assignees": Array [
+    "octocat",
+    "JasonEtco",
+  ],
+  "body": "Goodbye!",
+  "labels": Array [],
+  "milestone": 1,
+  "title": "Hello!",
+}
+`;
+
 exports[`create-an-issue creates a new issue 1`] = `
 Object {
   "assignees": Array [],

tests/index.test.ts

@@ -151,6 +151,14 @@ describe('create-an-issue', () => {
     expect(tools.log.success).toHaveBeenCalled()
   })
 
+  it('checks the value of update_existing', async () => {
+    process.env.INPUT_UPDATE_EXISTING = 'invalid'
+
+    await createAnIssue(tools)
+    expect(params).toMatchSnapshot()
+    expect(tools.exit.failure).toHaveBeenCalledWith('Invalid value update_existing=invalid, must be one of true or false')
+  })
+
   it('updates an existing issue with the same title', async () => {
     nock.cleanAll()
     nock('https://api.github.com')