chore: migrate to eslint defineConfig

Wow things are a mess.  tseslint is trying to stay compatible with eslint v8 while also keeping up with v9's defineConfig.  This causes some big type-incompatibilities in the more complicated plugins.  For now we'll ignore errors because it's runtime-compatible.

Author: JasonWeinzierl

src/bhs-e2e/eslint.config.mjs

@@ -1,13 +1,16 @@
+/* eslint-disable import-x/no-named-as-default */
 /* eslint-disable import-x/no-named-as-default-member */
+// @ts-check
 import js from '@eslint/js';
 import stylistic from '@stylistic/eslint-plugin';
+import { defineConfig } from 'eslint/config';
 import gitignore from 'eslint-config-flat-gitignore';
 import importX from 'eslint-plugin-import-x';
 import n from 'eslint-plugin-n';
 import * as wdio from 'eslint-plugin-wdio';
 import tseslint from 'typescript-eslint';
 
-export default tseslint.config(gitignore(), {
+export default defineConfig(gitignore(), {
   files: [
     '**/*.js',
     '**/*.mjs',
@@ -17,14 +20,15 @@ export default tseslint.config(gitignore(), {
     js.configs.recommended,
     stylistic.configs['disable-legacy'],
     stylistic.configs.customize({
-      flat: true,
       quotes: 'single',
       semi: true,
       jsx: false,
       braceStyle: '1tbs',
       commaDangle: 'always-multiline',
     }),
+    // @ts-expect-error
     importX.flatConfigs.recommended,
+    // @ts-expect-error
     importX.flatConfigs.typescript,
     n.configs['flat/recommended-module'],
   ],

src/bhs-web-angular-app/eslint.config.mjs

@@ -1,10 +1,12 @@
+/* eslint-disable import-x/no-named-as-default */
 /* eslint-disable import-x/no-named-as-default-member */
 /* eslint-disable import-x/no-rename-default */
 // @ts-check
 import js from '@eslint/js';
 import stylistic from '@stylistic/eslint-plugin';
 import vitest from '@vitest/eslint-plugin';
 import angular from 'angular-eslint';
+import { defineConfig } from 'eslint/config';
 import gitignore from 'eslint-config-flat-gitignore';
 import { importX } from 'eslint-plugin-import-x';
 import jsdoc from 'eslint-plugin-jsdoc';
@@ -13,14 +15,13 @@ import rxjsX from 'eslint-plugin-rxjs-x';
 import globals from 'globals';
 import tseslint from 'typescript-eslint';
 
-// TODO: tseslint.config() is now deprecated, replace with eslint/config defineConfig().
-export default tseslint.config(gitignore(), {
+export default defineConfig(gitignore(), {
   files: [
     '**/*.js',
     '**/*.mjs',
     '**/*.ts',
   ],
-  extends: [
+  extends: ([
     js.configs.recommended,
     stylistic.configs['disable-legacy'],
     stylistic.configs.customize({
@@ -30,10 +31,12 @@ export default tseslint.config(gitignore(), {
       braceStyle: '1tbs',
       commaDangle: 'always-multiline',
     }),
+    // @ts-expect-error -- community is struggling with growing pains right now and plugin types aren't type-compatible for now.
     importX.flatConfigs.recommended,
+    // @ts-expect-error -- ditto.
     importX.flatConfigs.typescript,
-    jsdoc.configs['flat/recommended-typescript-error'],
-  ],
+    jsdoc.configs['flat/recommended-mixed'],
+  ]),
   rules: {
     // #region General
     // Maximum cyclomatic complexity.

src/bhs-web-angular-app/package.json

@@ -38,6 +38,7 @@
     "@angular/build": "20.3.8",
     "@angular/cli": "20.3.8",
     "@angular/compiler-cli": "20.3.9",
+    "@eslint/config-helpers": "0.4.1",
     "@stylistic/eslint-plugin": "^5.5.0",
     "@tailwindcss/postcss": "^4.1.16",
     "@tailwindcss/typography": "^0.5.19",

yarn.lock

@@ -1126,12 +1126,12 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@eslint/config-helpers@npm:^0.4.1":
-  version: 0.4.2
-  resolution: "@eslint/config-helpers@npm:0.4.2"
+"@eslint/config-helpers@npm:0.4.1, @eslint/config-helpers@npm:^0.4.1":
+  version: 0.4.1
+  resolution: "@eslint/config-helpers@npm:0.4.1"
   dependencies:
-    "@eslint/core": "npm:^0.17.0"
-  checksum: 10c0/92efd7a527b2d17eb1a148409d71d80f9ac160b565ac73ee092252e8bf08ecd08670699f46b306b94f13d22e88ac88a612120e7847570dd7cdc72f234d50dcb4
+    "@eslint/core": "npm:^0.16.0"
+  checksum: 10c0/bb7dd534019a975320ac0f8e0699b37433cee9a3731354c1ee941648e6651032386e7848792060fb53a0fd603ea6cf7a101ed3bd5b82ee2f641598986d1e080a
   languageName: node
   linkType: hard
 
@@ -1144,15 +1144,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@eslint/core@npm:^0.17.0":
-  version: 0.17.0
-  resolution: "@eslint/core@npm:0.17.0"
-  dependencies:
-    "@types/json-schema": "npm:^7.0.15"
-  checksum: 10c0/9a580f2246633bc752298e7440dd942ec421860d1946d0801f0423830e67887e4aeba10ab9a23d281727a978eb93d053d1922a587d502942a713607f40ed704e
-  languageName: node
-  linkType: hard
-
 "@eslint/eslintrc@npm:^3.3.1":
   version: 3.3.1
   resolution: "@eslint/eslintrc@npm:3.3.1"
@@ -4194,6 +4185,7 @@ __metadata:
     "@angular/platform-browser": "npm:20.3.9"
     "@angular/router": "npm:20.3.9"
     "@auth0/auth0-angular": "npm:^2.3.0"
+    "@eslint/config-helpers": "npm:0.4.1"
     "@microsoft/applicationinsights-analytics-js": "npm:3.3.10"
     "@microsoft/applicationinsights-angularplugin-js": "npm:^15.3.8"
     "@microsoft/applicationinsights-web": "npm:^3.3.10"