style: use Finnish notation for subjects too

eslint-plugin-rxjs-x#91 discovered that suffix-subjects will allow the Finnish suffix too.

Author: JasonWeinzierl

src/bhs-web-angular-app/eslint.config.mjs

@@ -186,10 +186,6 @@ export default tseslint.config(gitignore(), {
           // Add paramMap|data to defaults for ActivatedRoute.
           '^(canActivate|canActivateChild|canDeactivate|canLoad|intercept|resolve|validate|paramMap|data)$': false,
         },
-        types: {
-          // Add the subjects to defaults to work with suffix-subjects.
-          '^(EventEmitter|BehaviorSubject|ReplaySubject|AsyncSubject|Subject)$': false,
-        },
       },
     ],
     'rxjs-x/suffix-subjects': 'warn',

src/bhs-web-angular-app/src/app/features/blog/components/posts-search/posts-search.component.ts

@@ -24,8 +24,8 @@ import { BlogService, PostPreview } from '@data/blog';
 export class PostsSearchComponent {
   private readonly blogService = inject(BlogService);
 
-  private readonly searchTextSubject = new BehaviorSubject('');
-  postsVm$ = this.searchTextSubject.pipe(
+  private readonly searchTextSubject$ = new BehaviorSubject('');
+  postsVm$ = this.searchTextSubject$.pipe(
     switchMap(searchText => this.blogService.searchPosts(searchText).pipe(
       map(posts => ({ posts, error: null })),
       // Must do the catchError in this inner observable so it doesn't replace the outer observable and break search.
@@ -48,6 +48,6 @@ export class PostsSearchComponent {
 
   onSearch(searchText: string): void {
     this.isLoading.set(true);
-    this.searchTextSubject.next(searchText);
+    this.searchTextSubject$.next(searchText);
   }
 }

src/bhs-web-angular-app/src/app/features/blog/pages/entry-edit/entry-edit.component.ts

@@ -34,7 +34,7 @@ export class EntryEditComponent {
   private readonly blogService = inject(BlogService);
   private readonly auth = inject(AuthService);
 
-  private readonly submittedRequestSubject = new Subject<{ slug: string; body: PostRequest }>();
+  private readonly submittedRequestSubject$ = new Subject<{ slug: string; body: PostRequest }>();
 
   // Emit a merged combination of the initial post loaded from the URL, and the updated post after a submission.
   vm$ = merge(this.getInitialPost$(), this.getUpdatedPost$()).pipe(
@@ -81,7 +81,7 @@ export class EntryEditComponent {
         return { post, categories: allCategories, isLoading: false, currentAuthor };
       }),
       // Handle when the user submits an update.
-      switchMap(vm => this.submittedRequestSubject.pipe(
+      switchMap(vm => this.submittedRequestSubject$.pipe(
         // If any request is submitted, display loading.
         map(() => true),
         // Before any request is submitted, don't show loading.
@@ -94,7 +94,7 @@ export class EntryEditComponent {
 
   private getUpdatedPost$(): Observable<EntryEditVm> {
     // Listen to the stream of submitted requests.
-    return this.submittedRequestSubject.pipe(
+    return this.submittedRequestSubject$.pipe(
       // Submit the first update and wait. All other requests are discarded.
       exhaustMap(request => this.blogService.updatePost(request.slug, request.body)),
       // When update is complete, re-fetch all possible categories.
@@ -122,6 +122,6 @@ export class EntryEditComponent {
   }
 
   onPublish(slug: string, request: PostRequest): void {
-    this.submittedRequestSubject.next({ slug, body: request });
+    this.submittedRequestSubject$.next({ slug, body: request });
   }
 }

src/bhs-web-angular-app/src/app/features/blog/pages/entry-new/entry-new.component.ts

@@ -33,8 +33,8 @@ export class EntryNewComponent {
   private readonly route = inject(ActivatedRoute);
   private readonly authorService = inject(AuthorService);
 
-  private readonly submittedRequestSubject = new Subject<PostRequest>();
-  private readonly routeErrorSubject = new Subject<{ newPost?: Post; error: unknown }>();
+  private readonly submittedRequestSubject$ = new Subject<PostRequest>();
+  private readonly routeErrorSubject$ = new Subject<{ newPost?: Post; error: unknown }>();
 
   vm$ = merge(this.getInitialVm$(), this.getCreatedPost$(), this.getRouteError$()).pipe(
     startWith({ allCategories: [], isLoading: true } as EntryNewVm),
@@ -49,7 +49,7 @@ export class EntryNewComponent {
   );
 
   onPublish(request: PostRequest): void {
-    this.submittedRequestSubject.next(request);
+    this.submittedRequestSubject$.next(request);
   }
 
   private getInitialVm$(): Observable<EntryNewVm> {
@@ -63,7 +63,7 @@ export class EntryNewComponent {
 
         return { currentAuthor, allCategories, isLoading: false };
       }),
-      switchMap(vm => this.submittedRequestSubject.pipe(
+      switchMap(vm => this.submittedRequestSubject$.pipe(
         map(() => true),
         startWith(false),
         map(isSubmitting => ({ ...vm, isLoading: isSubmitting })),
@@ -72,11 +72,11 @@ export class EntryNewComponent {
   }
 
   private getCreatedPost$(): Observable<EntryNewVm> {
-    return this.submittedRequestSubject.pipe(
+    return this.submittedRequestSubject$.pipe(
       exhaustMap(request => this.blogService.createPost(request)),
       map(newPost => {
         this.router.navigate(['../entry', newPost.slug], { relativeTo: this.route })
-        .catch((error: unknown) => { this.routeErrorSubject.next({ error, newPost }); });
+        .catch((error: unknown) => { this.routeErrorSubject$.next({ error, newPost }); });
 
         // Instead of mapping the post into the VM, just keep loading until the route changes.
         return { isLoading: true, allCategories: [], currentAuthor: null };
@@ -85,7 +85,7 @@ export class EntryNewComponent {
   }
 
   private getRouteError$(): Observable<never> {
-    return this.routeErrorSubject.pipe(
+    return this.routeErrorSubject$.pipe(
       map(({ error, newPost }) => {
         let msg = `An error occurred while navigating to new post '${newPost?.title ?? newPost?.slug ?? '(null)'}'.`;
         if (typeof error === 'object' && error && 'message' in error && typeof error.message === 'string') {