feat(no-misused-observables): check ctors too

Author: JasonWeinzierl

src/rules/no-misused-observables.ts

@@ -49,7 +49,7 @@ export const noMisusedObservablesRule = ruleCreator({
 
     const voidReturnChecks: TSESLint.RuleListener = {
       CallExpression: checkArguments,
-      // NewExpression: checkArguments,
+      NewExpression: checkArguments,
       // JSXAttribute: checkJSXAttribute,
       // ClassDeclaration: checkClassLikeOrInterfaceNode,
       // ClassExpression: checkClassLikeOrInterfaceNode,

tests/rules/no-misused-observables.test.ts

@@ -12,13 +12,24 @@ ruleTester({ types: true }).run('no-misused-observables', noMisusedObservablesRu
 
         [1, 2, 3].forEach((i): Observable<number> => { return of(i); });
         [1, 2, 3].forEach(i => of(i));
+
+        class Foo {
+          constructor(x: () => void) {}
+        }
+        new Foo(() => of(42));
       `,
       options: [{ checksVoidReturn: false }],
     },
     stripIndent`
       // void return argument; unrelated
       [1, 2, 3].forEach(i => i);
       [1, 2, 3].forEach(i => { return i; });
+
+      class Foo {
+        constructor(x: () => void) {}
+      }
+      new Foo(() => 42);
+      new Foo;
     `,
     stripIndent`
       // couldReturnType is bugged for block body implicit return types (#57)
@@ -79,6 +90,18 @@ ruleTester({ types: true }).run('no-misused-observables', noMisusedObservablesRu
                           ~~~~~~~~~~~~~~~~~~~~~~ [forbiddenVoidReturnArgument]
       `,
     ),
+    fromFixture(
+      stripIndent`
+        // void return argument; constructor
+        import { of } from "rxjs";
+
+        class Foo {
+          constructor(x: () => void) {}
+        }
+        new Foo(() => of(42));
+                ~~~~~~~~~~~~ [forbiddenVoidReturnArgument]
+      `,
+    ),
     fromFixture(
       stripIndent`
         // spread variable