fix: takeUntil can be before shareReplay

Author: JasonWeinzierl

src/rules/no-sharereplay-before-takeuntil.ts

@@ -1,6 +1,7 @@
 import { TSESTree as es } from '@typescript-eslint/utils';
-import { isCallExpression, isIdentifier, isLiteral, isMemberExpression, isObjectExpression, isProperty } from '../etc';
-import { ruleCreator } from '../utils';
+import { DEFAULT_VALID_POST_COMPLETION_OPERATORS } from '../constants';
+import { isIdentifier, isLiteral, isMemberExpression, isObjectExpression, isProperty } from '../etc';
+import { findIsLastOperatorOrderValid, ruleCreator } from '../utils';
 
 export const noSharereplayBeforeTakeuntilRule = ruleCreator({
   defaultOptions: [],
@@ -27,18 +28,18 @@ export const noSharereplayBeforeTakeuntilRule = ruleCreator({
         return;
       }
 
-      const takeUntilIndex = pipeCallExpression.arguments.findIndex(arg =>
-        isCallExpression(arg)
-        && (
-          (isIdentifier(arg.callee)
-            && arg.callee.name === 'takeUntil')
-          || (isMemberExpression(arg.callee)
-            && isIdentifier(arg.callee.property)
-            && arg.callee.property.name === 'takeUntil')
-        ),
+      const { isOrderValid, operatorNode: takeUntilNode } = findIsLastOperatorOrderValid(
+        pipeCallExpression,
+        /^takeUntil$/,
+        DEFAULT_VALID_POST_COMPLETION_OPERATORS,
       );
+      if (!isOrderValid || !takeUntilNode) {
+        // takeUntil is not present or in an unsafe position itself.
+        return;
+      }
 
-      if (takeUntilIndex === -1) {
+      if (takeUntilNode.range[0] < node.range[0]) {
+        // takeUntil is before shareReplay.
         return;
       }
 

tests/rules/no-sharereplay-before-takeuntil.test.ts

@@ -44,6 +44,15 @@ ruleTester({ types: false }).run('no-sharereplay-before-takeuntil', noSharerepla
       const sr = shareReplay({ refCount: false });
       a.pipe(sr, takeUntil(b));
     `,
+    stripIndent`
+      // shareReplay after takeUntil
+      import { of, takeUntil, shareReplay } from "rxjs";
+
+      const a = of("a");
+      const b = of("b");
+
+      a.pipe(takeUntil(b), shareReplay({ refCount: false }));
+    `,
     stripIndent`
       // unrelated
       import { of, takeUntil, toArray } from "rxjs";