refactor: sharereplay already defaults allowConfig true

Author: JasonWeinzierl

src/configs/recommended.ts

@@ -17,7 +17,7 @@ export const createRecommendedConfig = (
     'rxjs-x/no-internal': 'error',
     'rxjs-x/no-nested-subscribe': 'error',
     'rxjs-x/no-redundant-notify': 'error',
-    'rxjs-x/no-sharereplay': ['error', { allowConfig: true }],
+    'rxjs-x/no-sharereplay': 'error',
     'rxjs-x/no-subject-unsubscribe': 'error',
     'rxjs-x/no-unbound-methods': 'error',
     'rxjs-x/no-unsafe-subject-next': 'error',

src/configs/strict.ts

@@ -20,7 +20,7 @@ export const createStrictConfig = (
     'rxjs-x/no-internal': 'error',
     'rxjs-x/no-nested-subscribe': 'error',
     'rxjs-x/no-redundant-notify': 'error',
-    'rxjs-x/no-sharereplay': ['error', { allowConfig: true }],
+    'rxjs-x/no-sharereplay': 'error',
     'rxjs-x/no-subject-unsubscribe': 'error',
     'rxjs-x/no-topromise': 'error',
     'rxjs-x/no-unbound-methods': 'error',

tests/configs/recommended.test.ts

@@ -8,8 +8,10 @@ describe('recommended', () => {
     expect(config.plugins).toEqual({ 'rxjs-x': mockPlugin });
   });
 
-  it('should default no-sharereplay to allowConfig: true', () => {
+  it('should use the defaults of each rule', () => {
     expect(config.rules).instanceOf(Object);
-    expect(config.rules['rxjs-x/no-sharereplay']).toEqual(['error', { allowConfig: true }]);
+    for (const ruleEntry of Object.values(config.rules)) {
+      expect(ruleEntry).toEqual('error');
+    }
   });
 });