refactor: rename to no-unnecessary-collection

Author: JasonWeinzierl

README.md

@@ -146,7 +146,7 @@ The package includes the following rules.
 | [no-tap](docs/rules/no-tap.md)                                         | Disallow the `tap` operator.                                                                              |      |    |    |    | ❌  |
 | [no-topromise](docs/rules/no-topromise.md)                             | Disallow use of the `toPromise` method.                                                                   | ✅ 🔒 |    | 💡 | 💭 |    |
 | [no-unbound-methods](docs/rules/no-unbound-methods.md)                 | Disallow passing unbound methods.                                                                         | ✅ 🔒 |    |    | 💭 |    |
-| [no-unnecessary-combine](docs/rules/no-unnecessary-combine.md)         | Disallow unnecessary usage of combining operators with single values.                                     | 🔒   |    |    |    |    |
+| [no-unnecessary-collection](docs/rules/no-unnecessary-collection.md)   | Disallow unnecessary usage of collection arguments with single values.                                    | 🔒   |    |    |    |    |
 | [no-unsafe-catch](docs/rules/no-unsafe-catch.md)                       | Disallow unsafe `catchError` usage in effects and epics.                                                  |      |    |    | 💭 |    |
 | [no-unsafe-first](docs/rules/no-unsafe-first.md)                       | Disallow unsafe `first`/`take` usage in effects and epics.                                                |      |    |    | 💭 |    |
 | [no-unsafe-subject-next](docs/rules/no-unsafe-subject-next.md)         | Disallow unsafe optional `next` calls.                                                                    | ✅ 🔒 |    |    | 💭 |    |

docs/rules/no-unnecessary-combine.md renamed to docs/rules/no-unnecessary-collection.md

@@ -1,14 +1,14 @@
-# Disallow unnecessary usage of combining operators with single values (`rxjs-x/no-unnecessary-combine`)
+# Disallow unnecessary usage of collection arguments with single values (`rxjs-x/no-unnecessary-collection`)
 
 💼 This rule is enabled in the 🔒 `strict` config.
 
 <!-- end auto-generated rule header -->
 
-This rule effects failures when static observable creators that accept multiple observables
-(`combineLatest`, `forkJoin`, `merge`, `zip`, `concat`, `race`)
-are passed only a single observable.
+This rule effects failures when passing a collection (object or array) containing a single observable
+to the static observable creators that accept multiple observables
+(`combineLatest`, `forkJoin`, `merge`, `zip`, `concat`, `race`).
 Use of these creator functions with only a single observable
-can be replace with direct usage of the observable itself.
+can be replaced with direct usage of the observable itself.
 
 ## Rule details
 
@@ -50,10 +50,10 @@ const h$ = of(1);
 
 ## When Not To Use It
 
-If you don't care about unnecessary use of static observable creators,
+If you don't care about unnecessary usage of static observable creators,
 then you don't need this rule.
 
 ## Resources
 
-- [Rule source](/src/rules/no-unnecessary-combine.ts)
-- [Test source](/tests/rules/no-unnecessary-combine.test.ts)
+- [Rule source](/src/rules/no-unnecessary-collection.ts)
+- [Test source](/tests/rules/no-unnecessary-collection.test.ts)

src/configs/strict.ts

@@ -32,7 +32,7 @@ export const createStrictConfig = (
     'rxjs-x/no-subscribe-in-pipe': 'error',
     'rxjs-x/no-topromise': 'error',
     'rxjs-x/no-unbound-methods': 'error',
-    'rxjs-x/no-unnecessary-combine': 'error',
+    'rxjs-x/no-unnecessary-collection': 'error',
     'rxjs-x/no-unsafe-subject-next': 'error',
     'rxjs-x/no-unsafe-takeuntil': 'error',
     'rxjs-x/prefer-observer': 'error',

src/index.ts

@@ -40,7 +40,7 @@ import { noSubscribeInPipeRule } from './rules/no-subscribe-in-pipe';
 import { noTapRule } from './rules/no-tap';
 import { noTopromiseRule } from './rules/no-topromise';
 import { noUnboundMethodsRule } from './rules/no-unbound-methods';
-import { noUnnecessaryCombineRule } from './rules/no-unnecessary-combine';
+import { noUnnecessaryCollectionRule } from './rules/no-unnecessary-collection';
 import { noUnsafeCatchRule } from './rules/no-unsafe-catch';
 import { noUnsafeFirstRule } from './rules/no-unsafe-first';
 import { noUnsafeSubjectNext } from './rules/no-unsafe-subject-next';
@@ -88,7 +88,7 @@ const allRules = {
   'no-tap': noTapRule,
   'no-topromise': noTopromiseRule,
   'no-unbound-methods': noUnboundMethodsRule,
-  'no-unnecessary-combine': noUnnecessaryCombineRule,
+  'no-unnecessary-collection': noUnnecessaryCollectionRule,
   'no-unsafe-catch': noUnsafeCatchRule,
   'no-unsafe-first': noUnsafeFirstRule,
   'no-unsafe-subject-next': noUnsafeSubjectNext,

src/rules/no-unnecessary-combine.ts renamed to src/rules/no-unnecessary-collection.ts

@@ -5,11 +5,11 @@ import { MULTIPLE_OBSERVABLE_ACCEPTING_STATIC_OBSERVABLE_CREATORS, SOURCES_OBJEC
 import { getTypeServices, isArrayExpression, isObjectExpression, isProperty } from '../etc';
 import { ruleCreator } from '../utils';
 
-export const noUnnecessaryCombineRule = ruleCreator({
+export const noUnnecessaryCollectionRule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      description: 'Disallow unnecessary usage of combining operators with single values.',
+      description: 'Disallow unnecessary usage of collection arguments with single values.',
       recommended: 'strict',
       requiresTypeChecking: false,
     },
@@ -19,7 +19,7 @@ export const noUnnecessaryCombineRule = ruleCreator({
     schema: [],
     type: 'suggestion',
   },
-  name: 'no-unnecessary-combine',
+  name: 'no-unnecessary-collection',
   create: (context) => {
     const { couldBeType, couldBeObservable } = getTypeServices(context);
 

tests/rules/no-unnecessary-combine.test.ts renamed to tests/rules/no-unnecessary-collection.test.ts

@@ -1,9 +1,9 @@
 import { stripIndent } from 'common-tags';
-import { noUnnecessaryCombineRule } from '../../src/rules/no-unnecessary-combine';
+import { noUnnecessaryCollectionRule } from '../../src/rules/no-unnecessary-collection';
 import { fromFixture } from '../etc';
 import { ruleTester } from '../rule-tester';
 
-ruleTester({ types: true }).run('no-unnecessary-combine', noUnnecessaryCombineRule, {
+ruleTester({ types: true }).run('no-unnecessary-collection', noUnnecessaryCollectionRule, {
   valid: [
     // #region valid; multiple observables in array
     stripIndent`