feat: correctly flag dual recommended rules

Also fix test to ensure this doesn't get missed again.

Author: JasonWeinzierl

src/rules/no-topromise.ts

@@ -7,7 +7,7 @@ export const noTopromiseRule = ruleCreator({
   meta: {
     docs: {
       description: 'Disallow use of the `toPromise` method.',
-      recommended: 'strict',
+      recommended: 'recommended',
       requiresTypeChecking: true,
     },
     hasSuggestions: true,

src/rules/prefer-observer.ts

@@ -20,7 +20,7 @@ export const preferObserverRule = ruleCreator({
     docs: {
       description:
         'Disallow passing separate handlers to `subscribe` and `tap`.',
-      recommended: 'strict',
+      recommended: 'recommended',
       requiresTypeChecking: true,
     },
     fixable: 'code',

src/rules/prefer-root-operators.ts

@@ -22,7 +22,7 @@ export const preferRootOperatorsRule = ruleCreator({
   meta: {
     docs: {
       description: 'Disallow importing operators from `rxjs/operators`.',
-      recommended: 'strict',
+      recommended: 'recommended',
     },
     fixable: 'code',
     hasSuggestions: true,

src/rules/throw-error.ts

@@ -16,6 +16,7 @@ export const throwErrorRule = ruleCreator({
       description:
         'Enforce passing only `Error` values to `throwError`.',
       recommended: {
+        recommended: true,
         strict: [{ allowThrowingAny: false, allowThrowingUnknown: false }],
       },
       requiresTypeChecking: true,

tests/package.test.ts

@@ -70,13 +70,16 @@ describe('package', () => {
         } else if (ruleRec === 'strict') {
           expect(strictRules).toHaveProperty(fullRuleName);
           expect(strictRules[fullRuleName as keyof typeof strictRules]).toBe('error');
+          expect(recommendedRules).not.toHaveProperty(fullRuleName);
         } else {
           expect.fail(`Invalid recommended value for rule ${fullRuleName}: ${ruleRec}`);
         }
       } else {
         // Rule is part of several configs.
         if (ruleRec.recommended) {
           expect(recommendedRules).toHaveProperty(fullRuleName);
+        } else {
+          expect(recommendedRules).not.toHaveProperty(fullRuleName);
         }
         expect(strictRules).toHaveProperty(fullRuleName);
         expect(strictRules[fullRuleName as keyof typeof strictRules]).toBeInstanceOf(Array);