feat(no-misused-observables): class expressions

Author: JasonWeinzierl

src/rules/no-misused-observables.ts

@@ -1,4 +1,4 @@
-import { TSESTree as es, ESLintUtils, TSESLint } from '@typescript-eslint/utils';
+import { TSESTree as es, TSESLint as eslint, ESLintUtils } from '@typescript-eslint/utils';
 import * as tsutils from 'ts-api-utils';
 import ts from 'typescript';
 import { getTypeServices, isJSXExpressionContainer, isMethodDefinition, isPropertyDefinition } from '../etc';
@@ -47,20 +47,20 @@ export const noMisusedObservablesRule = ruleCreator({
     const [config = {}] = context.options;
     const { checksVoidReturn = true, checksSpreads = true } = config;
 
-    const voidReturnChecks: TSESLint.RuleListener = {
+    const voidReturnChecks: eslint.RuleListener = {
       CallExpression: checkArguments,
       NewExpression: checkArguments,
       JSXAttribute: checkJSXAttribute,
       ClassDeclaration: checkClassLikeOrInterfaceNode,
-      // ClassExpression: checkClassLikeOrInterfaceNode,
+      ClassExpression: checkClassLikeOrInterfaceNode,
       // TSInterfaceDeclaration: checkClassLikeOrInterfaceNode,
       // Property: checkProperty,
       // ReturnStatement: checkReturnStatement,
       // AssignmentExpression: checkAssignment,
       // VariableDeclarator: checkVariableDeclarator,
     };
 
-    const spreadChecks: TSESLint.RuleListener = {
+    const spreadChecks: eslint.RuleListener = {
       SpreadElement: (node) => {
         if (couldBeObservable(node.argument)) {
           context.report({

tests/rules/no-misused-observables.test.ts

@@ -80,6 +80,10 @@ ruleTester({ types: true }).run('no-misused-observables', noMisusedObservablesRu
         class Bar extends Foo {
           foo(): Observable<number> { return of(42); }
         }
+
+        const Baz = class extends Foo {
+          foo(): Observable<number> { return of(42); }
+        }
       `,
       options: [{ checksVoidReturn: false }],
     },
@@ -341,6 +345,36 @@ ruleTester({ types: true }).run('no-misused-observables', noMisusedObservablesRu
         }
       `,
     ),
+    fromFixture(
+      stripIndent`
+        // void return inherited method; class expression; extends
+        import { Observable, of } from "rxjs";
+
+        const Foo = class {
+          foo(): void {}
+        }
+
+        const Bar = class extends Foo {
+          foo(): Observable<number> { return of(42); }
+          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [forbiddenVoidReturnInheritedMethod { "heritageTypeName": "Foo" }]
+        }
+      `,
+    ),
+    fromFixture(
+      stripIndent`
+        // void return inherited method; class expression; implements
+        import { Observable, of } from "rxjs";
+
+        interface Foo {
+          foo(): void;
+        }
+
+        const Bar = class implements Foo {
+          foo(): Observable<number> { return of(42); }
+          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [forbiddenVoidReturnInheritedMethod { "heritageTypeName": "Foo" }]
+        }
+      `,
+    ),
     // #endregion invalid; void return inherited method
     // #region invalid; spread
     fromFixture(