chore(deps): decrease min tseslint version (#10)

- Decrease minimum version of `typescript-eslint` for more compatibility
(now matches `import-x` plugin).
- Internally bump linter deps and fix new errors.

Would've liked to drop to `typescript-eslint` v7 for even more
compatibility, but had some early problems. Maybe in the future.

Author: JasonWeinzierl

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- Decrease minimum `typescript-eslint` version to ^8.1.0 (matches import-x plugin).
+
 ## v0.2.0
 
 - Improved CJS typing to avoid needing `.default`.

package.json

@@ -53,8 +53,8 @@
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.12.2",
-    "@typescript-eslint/utils": "^8.12.2",
+    "@typescript-eslint/scope-manager": "^8.1.0",
+    "@typescript-eslint/utils": "^8.1.0",
     "common-tags": "^1.8.0",
     "decamelize": "^5.0.1",
     "ts-api-utils": "^1.3.0",
@@ -66,28 +66,28 @@
     "typescript": ">=4.2.0"
   },
   "devDependencies": {
-    "@eslint/js": "^9.13.0",
+    "@eslint/js": "^9.14.0",
     "@stylistic/eslint-plugin": "^2.10.1",
     "@types/common-tags": "^1.8.4",
     "@types/node": "^18.18.0",
-    "@typescript-eslint/rule-tester": "^8.12.2",
+    "@typescript-eslint/rule-tester": "^8.13.0",
     "@typescript/vfs": "^1.6.0",
     "@vitest/coverage-v8": "^2.1.4",
     "@vitest/eslint-plugin": "^1.1.7",
     "bumpp": "^9.8.0",
-    "eslint": "^9.13.0",
+    "eslint": "^9.14.0",
     "eslint-config-flat-gitignore": "^0.3.0",
     "eslint-doc-generator": "^1.7.1",
     "eslint-import-resolver-typescript": "^3.6.3",
     "eslint-plugin-eslint-plugin": "^6.3.1",
     "eslint-plugin-import-x": "^4.4.0",
-    "eslint-plugin-n": "^17.12.0",
+    "eslint-plugin-n": "^17.13.1",
     "markdownlint-cli2": "^0.14.0",
     "rxjs": "^7.0.0",
     "tsup": "^8.3.5",
     "tsx": "^4.19.2",
     "typescript": "~5.6.3",
-    "typescript-eslint": "^8.12.2",
+    "typescript-eslint": "^8.13.0",
     "vitest": "^2.1.4"
   },
   "engines": {

src/rules/finnish.ts

@@ -118,8 +118,8 @@ export const finnishRule = ruleCreator({
           }
         : () => { /* noop */ };
       if (
-        couldBeObservable(typeNode || nameNode)
-        || couldReturnObservable(typeNode || nameNode)
+        couldBeObservable(typeNode ?? nameNode)
+        || couldReturnObservable(typeNode ?? nameNode)
       ) {
         for (const name of names) {
           const { regExp, validate } = name;
@@ -131,8 +131,8 @@ export const finnishRule = ruleCreator({
         for (const type of types) {
           const { regExp, validate } = type;
           if (
-            (couldBeType(typeNode || nameNode, regExp)
-              || couldReturnType(typeNode || nameNode, regExp))
+            (couldBeType(typeNode ?? nameNode, regExp)
+              || couldReturnType(typeNode ?? nameNode, regExp))
             && !validate
           ) {
             shouldNotBeFinnish();

src/rules/no-finnish.ts

@@ -26,8 +26,8 @@ export const noFinnishRule = ruleCreator({
 
     function checkNode(nameNode: es.Node, typeNode?: es.Node) {
       if (
-        couldBeObservable(typeNode || nameNode)
-        || couldReturnObservable(typeNode || nameNode)
+        couldBeObservable(typeNode ?? nameNode)
+        || couldReturnObservable(typeNode ?? nameNode)
       ) {
         const tsNode = esTreeNodeToTSNodeMap.get(nameNode);
         if (/[$]+$/.test(tsNode.getText())) {

src/rules/suffix-subjects.ts

@@ -76,11 +76,11 @@ export const suffixSubjectsRule = ruleCreator({
       const text = tsNode.getText();
       if (
         !suffixRegex.test(text)
-        && couldBeType(typeNode || nameNode, 'Subject')
+        && couldBeType(typeNode ?? nameNode, 'Subject')
       ) {
         for (const type of types) {
           const { regExp, validate } = type;
-          if (couldBeType(typeNode || nameNode, regExp) && !validate) {
+          if (couldBeType(typeNode ?? nameNode, regExp) && !validate) {
             return;
           }
         }