fix(no-floating-observables): reduce selectors for perf

Go back to more limited selectors for performance.  Still checking the expression's type (call or unary) so we don't type-check too early.

Author: JasonWeinzierl

src/rules/no-floating-observables.ts

@@ -41,28 +41,25 @@ export const noFloatingObservablesRule = ruleCreator({
     const [config = {}] = context.options;
     const { ignoreVoid = true } = config;
 
-    return {
-      ExpressionStatement: (node: es.ExpressionStatement) => {
-        const { expression } = node;
+    function checkNode(node: es.Expression) {
+      if (!ignoreVoid && isUnaryExpression(node) && node.operator === 'void') {
+        node = node.argument;
+      }
 
-        if (isCallExpression(expression) && couldBeObservable(expression)) {
-          context.report({
-            messageId: ignoreVoid ? 'forbidden' : 'forbiddenNoVoid',
-            node,
-          });
-          return;
-        }
+      if (isCallExpression(node) && couldBeObservable(node)) {
+        context.report({
+          messageId: ignoreVoid ? 'forbidden' : 'forbiddenNoVoid',
+          node,
+        });
+      }
+    }
 
-        if (!ignoreVoid && isUnaryExpression(expression)) {
-          const { operator, argument } = expression;
-          if (operator === 'void' && isCallExpression(argument) && couldBeObservable(argument)) {
-            context.report({
-              messageId: 'forbiddenNoVoid',
-              node: argument,
-            });
-            return;
-          }
-        }
+    return {
+      'ExpressionStatement > CallExpression': (node: es.CallExpression) => {
+        checkNode(node);
+      },
+      'ExpressionStatement > UnaryExpression': (node: es.UnaryExpression) => {
+        checkNode(node);
       },
     };
   },

tests/rules/no-floating-observables.test.ts

@@ -47,7 +47,7 @@ ruleTester({ types: true }).run('no-floating-observables', noFloatingObservables
         }
 
         functionSource();
-        ~~~~~~~~~~~~~~~~~ [forbidden]
+        ~~~~~~~~~~~~~~~~ [forbidden]
       `,
     ),
     fromFixture(
@@ -58,7 +58,7 @@ ruleTester({ types: true }).run('no-floating-observables', noFloatingObservables
         const arrowSource = () => of(42);
 
         arrowSource();
-        ~~~~~~~~~~~~~~ [forbidden]
+        ~~~~~~~~~~~~~ [forbidden]
       `,
     ),
     fromFixture(