forked from cartant/eslint-plugin-rxjs
-
Notifications
You must be signed in to change notification settings - Fork 3
Closed
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Milestone
Description
Since the recommended
config was last updated in 2021, a few rules were improved or added. I'd like to add the following to the recommended
config:
prefer-observer
- Had a fixer added
- RxJS has since deprecated passing separate callback arguments
throw-error
- Narrowed to just the
throwError
function instead of regular JavaScriptthrow
feat(throw-error)!: stop linting throw statements #22
- Narrowed to just the
prefer-root-operators
feat(prefer-root-operators): new rule #34- Adding this rule would also require bumping the RxJS peer dependency from v7.0 to v7.2.
no-topromise
- RxJS has deprecated this method
- Rule has been enhanced with editor suggestions feat(no-topromise): suggest
lastValueFrom
orfirstValueFrom
#38
Additionally:
- Change
no-implicit-any-catch
'sallowExplicitAny
totrue
in thein the rule's defaults.recommended
config- It currently defaults to
false
. However, other rules in this plugin allowany
by default, so this is inconsistent. - More lax codebases tend to turn this option on because they haven't banned explicit
any
completely. - We should enforce banning
any
more consistently in the proposedstrict
config: Introduce astrict
config #36
- It currently defaults to
Feedback is welcome.
json-derulo
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed