No nested pipe similar to no-nested-subscribe #134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is just new rule created based on the no-nested-subscribe, in our code we found this one of big issue when its making code complex and have certain issue as well so we wanted to avoid nested pipe in the code currently there is not other solution available in the next
example in the docs about the growing code face issues with nested pipes for which we require this rule to avoid this complexity
added new test file for no-nested-pipe valid and invalid scenarios
rule usage standalone code for playground
test description update
JasonWeinzierl
requested changes
Jan 28, 2025
Owner
There was a problem hiding this comment.
Thanks! I've left some comments. Additionally:
- Run
yarn lintandyarn typecheckand fix any problems. - Run
yarn docsto auto-update the documentation instead of manually updating it. - You may need to re-create your branch off this repository instead of cartant's, since we've upgraded things like dependencies and the testing framework.
| /** | ||
| * @license Use of this source code is governed by an MIT-style license that | ||
| * can be found in the LICENSE file at https://github.com/cartant/eslint-plugin-rxjs | ||
| */ |
Owner
There was a problem hiding this comment.
This license header can be removed (and in the test file too).
|
|
||
| import { TSESTree as es } from "@typescript-eslint/experimental-utils"; | ||
| import { getParent, getTypeServices } from "eslint-etc"; | ||
| import { ruleCreator } from "../utils"; |
Owner
There was a problem hiding this comment.
Since we've upgraded typescript-eslint and dropped the dependency on eslint-etc, you'll need slightly separate imports:
import { TSESTree as es } from '@typescript-eslint/utils';
import { getTypeServices } from '../etc';
...And instead of getParent, you can just do node.parent.
| }, | ||
| }); | ||
|
|
||
| export = rule; |
Owner
There was a problem hiding this comment.
We're exporting rules slightly different to support ESM too. Do:
export const noNestedPipeRule = ruleCreator({
...
Owner
There was a problem hiding this comment.
You'll need to add the rule to index.ts (we have a unit test to ensure it gets added).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I would like to add new rule: no-nested-pipe
Last year, my team have spent significant effort on improving the maintainability and readability of rxjs statement in the codebase. Avoiding nested pipe has been the most useful rule on driving the better behavior in this area. The team have been enforcing this manually through PR review check last year. I have come cross your library and find it very useful, hence would like to introduce no-nested-pipe rule so that we could all benefit from it.
would you please review this PR and suggest if there is any correction and could please approve this PR if everything is ok