Skip to content

feat(strict): remove no-explicit-generics from strict #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2024
Merged

feat(strict): remove no-explicit-generics from strict #78

merged 2 commits into from
Dec 6, 2024

Conversation

@JasonWeinzierl
Copy link
Owner

@JasonWeinzierl JasonWeinzierl commented Dec 6, 2024

There are known problems with this rule (#77), so we're removing it to avoid unnecessary problems for now.

@JasonWeinzierl
feat(strict): remove no-explicit-generics
ff68d57 
There are known problems with this rule, so we're removing it to avoid unnecessary problems for now.
@JasonWeinzierl
docs(no-explicit-generics): add known union problem
07fe538
@github-actions
Copy link

github-actions bot commented Dec 6, 2024

LCOV of commit 07fe538 during .github/workflows/ci.yml #207

Summary coverage rate:
  lines......: 96.7% (4250 of 4396 lines)
  functions..: 96.1% (270 of 281 functions)
  branches...: 91.1% (932 of 1023 branches)

Files changed coverage rate:
                                         |Lines       |Functions  |Branches    
  Filename                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================
  src/configs/strict.ts                  | 100%     41| 100%     1| 100%      1
  src/rules/no-explicit-generics.ts      | 100%     53| 100%     4| 100%     10

@JasonWeinzierl JasonWeinzierl merged commit c97c29f into main Dec 6, 2024
3 checks passed
@JasonWeinzierl JasonWeinzierl deleted the remove-explicit-generics-from-strict branch December 6, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JasonWeinzierl