Move table generation logic into a helper

Author: Jaspaul

src/Console/ListCommand.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Support\Collection;
 use Jaspaul\LaravelRollout\FeaturePresenter;
+use Jaspaul\LaravelRollout\Helpers\FeatureTable;
 
 class ListCommand extends RolloutCommand
 {
@@ -22,31 +23,19 @@ class ListCommand extends RolloutCommand
     protected $description = 'Returns a list of all the features that have been created.';
 
     /**
-     * Returns the feature rows.
+     * Outputs a table containing the features configured in rollout.
      *
-     * @return \Illuminate\Support\Collection
-     *         A list of features.
+     * @return void
      */
-    protected function getRows() : Collection
+    public function handle()
     {
-        return (new Collection($this->rollout->features()))
+        $presenters = (new Collection($this->rollout->features()))
             ->map(function ($feature) {
                 return new FeaturePresenter($this->rollout->get($feature));
-            })->map(function (FeaturePresenter $feature) {
-                return $feature->toArray();
             });
-    }
 
-    /**
-     * Outputs a table containing the features configured in rollout.
-     *
-     * @return void
-     */
-    public function handle()
-    {
-        $headers = ['name', 'status', 'request-parameter', 'percentage', 'users'];
-        $rows = $this->getRows();
+        $table = new FeatureTable($presenters);
 
-        $this->table($headers, $rows);
+        $this->table($table->getHeaders()->toArray(), $table->getRows());
     }
 }

src/Helpers/FeatureTable.php

@@ -0,0 +1,53 @@
+<?php
+
+namespace Jaspaul\LaravelRollout\Helpers;
+
+use Opensoft\Rollout\Feature;
+use Illuminate\Support\Collection;
+use Jaspaul\LaravelRollout\FeaturePresenter;
+
+class FeatureTable
+{
+    /**
+     * The presenters to render into a table.
+     *
+     * @var \Illuminate\Support\Collection
+     */
+    protected $presenters;
+
+    /**
+     * Filters the provided collection into presenters. It also grabs the first
+     * presenter and generates the headers from it's properties.
+     *
+     * @param \Illuminate\Support\Collection $presenters
+     *        A list of presenters to render into a table.
+     */
+    public function __construct(Collection $presenters) {
+        $this->presenters = $presenters->filter(function ($presenter) {
+            return $presenter instanceof FeaturePresenter;
+        });
+    }
+
+    /**
+     * Returns the key's for the feature array.
+     *
+     * @return \Illuminate\Support\Collection
+     */
+    public function getHeaders() : Collection
+    {
+        $presenter = new FeaturePresenter(new Feature(''));
+        return new Collection(array_keys($presenter->toArray()));
+    }
+
+    /**
+     * Returns each presenter as it's array representation.
+     *
+     * @return \Illuminate\Support\Collection
+     */
+    public function getRows() : Collection
+    {
+        return $this->presenters->map(function (FeaturePresenter $feature) {
+            return $feature->toArray();
+        });
+    }
+}

tests/Console/ListCommandTest.php

@@ -3,6 +3,7 @@
 namespace Tests\Drivers;
 
 use Tests\TestCase;
+use Opensoft\Rollout\Feature;
 use Opensoft\Rollout\Rollout;
 use Illuminate\Support\Facades\Artisan;
 use Illuminate\Contracts\Console\Kernel;
@@ -15,16 +16,24 @@ class ListCommandTest extends TestCase
      */
     function it_returns_an_empty_table_if_there_are_no_stored_features()
     {
-        $expected = "+------+--------+-------------------+------------+-------+
-| name | status | request-parameter | percentage | users |
-+------+--------+-------------------+------------+-------+
-";
-
         Artisan::call('rollout:list', []);
 
         $output = $this->app[Kernel::class]->output();
+        $output = explode("\n", $output);
+
+        $this->assertEquals(4, count($output));
+
+        // The first row is a header row +----+----+ ...
+        $this->assertTrue((bool) preg_match('/[+-]+/', $output[0]));
+
+        // The second row contains each of the keys for a feature presenter
+        $presenter = new FeaturePresenter(new Feature(''));
+        foreach (array_keys($presenter->toArray()) as $key) {
+            $this->assertContains($key, $output[1]);
+        }
 
-        $this->assertSame($expected, $output);
+        // The first row is a seperator row +----+----+ ...
+        $this->assertTrue((bool) preg_match('/[+-]+/', $output[2]));
     }
 
     /**

tests/Helpers/FeatureTableTest.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace Tests\Helpers;
+
+use Tests\TestCase;
+use Opensoft\Rollout\Feature;
+use Illuminate\Support\Collection;
+use Jaspaul\LaravelRollout\FeaturePresenter;
+use Jaspaul\LaravelRollout\Helpers\FeatureTable;
+
+class FeatureTableTest extends TestCase
+{
+    /**
+     * @test
+     */
+    function get_headers_should_return_same_keys_as_the_feature_presenter_to_array_method()
+    {
+        $presenter = new FeaturePresenter(new Feature('test'));
+
+        $table = new FeatureTable(new Collection());
+
+        $this->assertSame(array_keys($presenter->toArray()), $table->getHeaders()->toArray());
+    }
+
+    /**
+     * @test
+     */
+    function get_rows_will_only_return_rows_for_feature_presenters_in_the_collection()
+    {
+        $presenter = new FeaturePresenter(new Feature('test'));
+        $collection = new Collection([$presenter, [], 'hi', 'alpha']);
+
+        $table = new FeatureTable($collection);
+
+        $this->assertEquals(1, $table->getRows()->count());
+        $this->assertSame($presenter->toArray(), $table->getRows()->first());
+    }
+}